OLS-2629: Vale checks for modules in about assembly by rh-tokeefe · Pull Request #106325 · openshift/openshift-docs

rh-tokeefe · 2026-02-10T21:38:22Z

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Issue:
https://issues.redhat.com/browse/OLS-2629

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2026-02-10T21:38:26Z

@rh-tokeefe: This pull request references OLS-2629 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2026-02-10T21:49:24Z

🤖 Wed Feb 18 16:12:50 - Prow CI generated the docs preview:

https://106325--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/about/ols-about-openshift-lightspeed.html

openshift-ci-robot · 2026-02-13T17:58:23Z

@rh-tokeefe: This pull request references OLS-2629 which is a valid jira issue.

Details

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Issue:
https://issues.redhat.com/browse/OLS-2629

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gabriel-rh

LGTM - some minor comments

gabriel-rh · 2026-02-18T15:20:11Z

modules/ols-about-running-openshift-lightspeed-in-disconnected-mode.adoc

 [role="_abstract"]

-{ols-long} supports operation in disconnected environments that do not have full internet access.
+{ols-long} works in disconnected clusters that do not without full internet access.


missing work here

gabriel-rh · 2026-02-18T15:21:45Z

modules/ols-disabling-data-collection-operator.adoc

@@ -43,7 +42,8 @@ spec:
      feedbackDisabled: true # <1>


I think you need to remove the # <1> etc here

Thank you! Done

gabriel-rh · 2026-02-18T15:22:25Z

modules/ols-feedback-collection-overview.adoc

 {ols-long} collects opt-in user feedback from the virtual assistant interface to analyze response accuracy and improve Service quality.

-If you submit feedback, the feedback score (thumbs up or down), text feedback (if entered), your query, and the large language model (LLM) provider response are stored and sent to {red-hat} on the same schedule as transcript collection. If you are using the filtering and redaction functionality, the filtered or redacted content is sent to {red-hat}. {red-hat} will not see the original non-redacted content, and the redaction takes place before any content is captured in logs.
+If you submit feedback, {red-hat} stores and receives your feedback score, text, and query. {red-hat} also receive the large language model (LLM) response on the same schedule as transcripts. When you use the redaction tools, {red-hat} receives only the filtered data. {red-hat} does not see the original data. {ols-long} hides your data before the system logs it.


Suggested change

If you submit feedback, {red-hat} stores and receives your feedback score, text, and query. {red-hat} also receive the large language model (LLM) response on the same schedule as transcripts. When you use the redaction tools, {red-hat} receives only the filtered data. {red-hat} does not see the original data. {ols-long} hides your data before the system logs it.

If you submit feedback, {red-hat} stores and receives your feedback score, text, and query. {red-hat} also receives the large language model (LLM) response on the same schedule as transcripts. When you use the redaction tools, {red-hat} receives only the filtered data. {red-hat} does not see the original data. {ols-long} hides your data before the system logs it.

gabriel-rh · 2026-02-18T15:23:18Z

modules/ols-large-language-model-requirements.adoc

 {ols-long} supports Software as a Service (SaaS) and self-hosted large language model (LLM) providers that meet defined authentication requirements.

-The LLM is a type of machine learning model that interprets and generates human-like language. When an LLM is used with a virtual assistant, the LLM can accurately interpret questions and provide helpful answers in a conversational manner. The {ols-long} Service must have access to an LLM provider. 
+The LLM is a type of machine learning model that interprets and generates human-like language. When you use a LLM with a virtual assistant, the LLM can accurately interpret questions and offers helpful answers in a conversational manner. The {ols-long} Service must have access to a LLM provider. 


Suggested change

The LLM is a type of machine learning model that interprets and generates human-like language. When you use a LLM with a virtual assistant, the LLM can accurately interpret questions and offers helpful answers in a conversational manner. The {ols-long} Service must have access to a LLM provider.

The LLM is a type of machine learning model that interprets and generates human-like language. When you use an LLM with a virtual assistant, the LLM can accurately interpret questions and offers helpful answers in a conversational manner. The {ols-long} Service must have access to an LLM provider.

Understood. Discussed in slack. Using ISG.

gabriel-rh · 2026-02-18T15:23:58Z

modules/ols-large-language-model-requirements.adoc

+The LLM is a type of machine learning model that interprets and generates human-like language. When you use a LLM with a virtual assistant, the LLM can accurately interpret questions and offers helpful answers in a conversational manner. The {ols-long} Service must have access to a LLM provider. 

-The Service does not provide an LLM for you, so you must configure the LLM prior to installing the {ols-long} Operator. 
+The Service does not provide a LLM for you, so you must configure the LLM before installing the {ols-long} Operator. 


openshift-ci · 2026-02-18T16:15:25Z

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rh-tokeefe · 2026-02-18T16:25:13Z

/cherrypick lightspeed-docs-1.0

openshift-cherrypick-robot · 2026-02-18T16:26:09Z

@rh-tokeefe: new pull request created: #106908

Details

In response to this:

/cherrypick lightspeed-docs-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2026

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2026

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2026

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2026

rh-tokeefe force-pushed the OLS-2629 branch from 87c5e2b to 366f41b Compare February 13, 2026 17:37

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2026

rh-tokeefe force-pushed the OLS-2629 branch from 3915907 to 3f01c15 Compare February 13, 2026 17:57

rh-tokeefe force-pushed the OLS-2629 branch from ccb46ba to 3d784cf Compare February 17, 2026 19:55

gabriel-rh approved these changes Feb 18, 2026

View reviewed changes

OLS-2629: Vale checks for modules in about assembly

241df11

rh-tokeefe force-pushed the OLS-2629 branch from 69a8e37 to 241df11 Compare February 18, 2026 16:06

rh-tokeefe merged commit 9703cdf into openshift:lightspeed-docs-main Feb 18, 2026
2 checks passed

openshift-cherrypick-robot mentioned this pull request Feb 18, 2026

[lightspeed-docs-1.0] OLS-2629: Vale checks for modules in about assembly #106908

Merged

	If you submit feedback, {red-hat} stores and receives your feedback score, text, and query. {red-hat} also receive the large language model (LLM) response on the same schedule as transcripts. When you use the redaction tools, {red-hat} receives only the filtered data. {red-hat} does not see the original data. {ols-long} hides your data before the system logs it.
	If you submit feedback, {red-hat} stores and receives your feedback score, text, and query. {red-hat} also receives the large language model (LLM) response on the same schedule as transcripts. When you use the redaction tools, {red-hat} receives only the filtered data. {red-hat} does not see the original data. {ols-long} hides your data before the system logs it.

	The LLM is a type of machine learning model that interprets and generates human-like language. When you use a LLM with a virtual assistant, the LLM can accurately interpret questions and offers helpful answers in a conversational manner. The {ols-long} Service must have access to a LLM provider.
	The LLM is a type of machine learning model that interprets and generates human-like language. When you use an LLM with a virtual assistant, the LLM can accurately interpret questions and offers helpful answers in a conversational manner. The {ols-long} Service must have access to an LLM provider.

Conversation

rh-tokeefe commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 10, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 13, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabriel-rh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 18, 2026

Uh oh!

Uh oh!

rh-tokeefe commented Feb 18, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rh-tokeefe commented Feb 10, 2026 •

edited

Loading

openshift-ci-robot commented Feb 10, 2026 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Feb 10, 2026 •

edited

Loading

openshift-ci-robot commented Feb 13, 2026 •

edited by openshift-ci bot

Loading