USHIFT-7223: Automate Polarion tests OCP-66820 and OCP-66882#6905
Open
agullon wants to merge 5 commits into
Open
USHIFT-7223: Automate Polarion tests OCP-66820 and OCP-66882#6905agullon wants to merge 5 commits into
agullon wants to merge 5 commits into
Conversation
Add Robot Framework tests for prerun data management scenarios: - OCP-66820: Verify that when the version file indicates a version 3 minors behind the executable (exceeding MAX_VERSION_SKEW=2), MicroShift fails to start and logs the failure reason to prerun_failed.log, which is then reported by greenboot healthcheck. - OCP-66882: Verify that when the MicroShift data directory is removed but health.json shows healthy status, MicroShift starts fresh as if it were the first run, ignoring the stale health info. Both tests are added to existing CI scenarios: - Presubmit: el98-src@backup-and-restore-on-reboot.sh - Release: el98-lrel@backups.sh Ref: USHIFT-7223 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
openshift-ci-robot
added
the
jira/valid-reference
|
@agullon: This pull request references USHIFT-7223 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA new Robot Framework suite adds prerun data management coverage for version-file rollback and missing-data-directory scenarios. Two scenario scripts include the suite in test runs, and reboot waiting is extended for host recovery. ChangesPrerun Data Management Tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
Author
|
/retest |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Contributor
Author
|
/retest |
- Add Make New SSH Connection to Greenboot Health Check Should Be Finished keyword to survive greenboot-triggered reboots during the retry loop (SSH connection dies on each reboot) - Add initial reboot to OCP-66882 test to ensure a backup exists before testing fresh start behavior, matching Polarion step 1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
ARM (Graviton) CI instances take significantly longer to complete reboot cycles compared to x86. SSH typically becomes available in ~60-120s on ARM vs ~30-50s on x86. When tests involve destructive operations like removing /var/lib/microshift followed by a fresh bootstrap (certificate generation, etcd initialization), the total reboot cycle on ARM can reach ~400s, exceeding the previous 5m (300s) timeout. This was observed in PR openshift#6905 where the new prerun-data-management tests triggered reboot timeouts exclusively on ARM jobs, while identical x86 runs passed comfortably. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Contributor
Author
|
/test e2e-aws-tests-release |
Contributor
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/suites/backup/prerun-data-management.robotprerun_failed.log, reported by greenboot healthcheck/var/lib/microshiftwhilehealth.jsonshows healthy causes MicroShift to start fresh, ignoring stale health infoel98-src@backup-and-restore-on-reboot.shandel98-lrel@backups.sh)Reboot MicroShift Hosttimeout from 5m to 7m to accommodate ARM CIARM reboot timeout fix
The new prerun-data-management tests involve multiple reboots, including a destructive
cycle that removes
/var/lib/microshiftand triggers a full MicroShift bootstrap fromscratch (certificate generation, etcd initialization, etc.).
On ARM (Graviton) CI instances, reboot cycles are significantly slower than x86:
The previous 5m (300s) timeout in
Reboot MicroShift Hostwas insufficient for ARM,causing test failures exclusively on ARM jobs while identical x86 runs passed. Bumping
to 7m provides enough headroom without masking genuine hangs.
Test plan
el98-src@backup-and-restore-on-rebootpresubmit scenario — verify both existing and new tests passel98-lrel@backupsrelease scenario — verify both existing and new tests passprerun_failed.log🤖 Generated with Claude Code
Summary by CodeRabbit