USHIFT-7169: Add RHEL 10.2 RPM standard release test scenario#6873
Conversation
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds RHEL 10.2 bootc test scenario scripts with repository configuration and VM lifecycle helpers. Updates build and test scripts across shell and Python to detect RHEL major version dynamically instead of hardcoding RHEL 9. Bumps image blueprint to 10.2 and adjusts Composer package selection for RHEL 10-specific build tools. ChangesRHEL 10.2 test scenarios and dynamic version parametrization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~13 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test ci/prow/e2e-aws-tests-bootc-release-el10 |
|
/test e2e-aws-tests-bootc-release-el10 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/scenarios-bootc/el10/releases/el102`@rpm-standard2.sh:
- Around line 123-129: Add the missing OS version assertion to the run_tests
call in el102@rpm-standard2.sh to match the paired scenario
el102@rpm-standard1.sh. Include a new variable assignment for
EXPECTED_OS_VERSION:10.2 alongside the existing SOURCE_REPO_URL and
TARGET_VERSION variables in the run_tests invocation to ensure provisioning
drift is validated against the explicit 10.2 target.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6ae7012e-c24f-4797-9441-4440bba955fd
📒 Files selected for processing (2)
test/scenarios-bootc/el10/releases/el102@rpm-standard1.shtest/scenarios-bootc/el10/releases/el102@rpm-standard2.sh
|
/test e2e-aws-tests-bootc-release-el10 |
|
@agullon: This pull request references USHIFT-7169 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label tide/merge-method-squash |
|
/test e2e-aws-tests-bootc-release-el10 |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-aws-tests-bootc-release-el10 |
|
/test e2e-aws-tests-release |
1 similar comment
|
/test e2e-aws-tests-release |
|
/retest |
|
/hold This PR is blocked by:
Once those merge, this PR will need a rebase to drop the overlapping changes (
|
a8682c3 to
4d58812
Compare
Add el102@rpm-standard1.sh and el102@rpm-standard2.sh under
test/scenarios-bootc/el10/releases/ for testing MicroShift RPM
install/remove on bare RHEL 10.2 VMs.
Adapted from el98@rpm-standard{1,2}.sh with RHEL 10 repo patterns:
- rhel102-installer VM image
- CDN repo files with entitlement certs for rhocp/fast-datapath
- Subscription-manager release set to 10.2
Parameterize hardcoded rhel-9/el9 references in CI scripts with
runtime OS version detection via RHEL_MAJOR exported from
common_versions.sh. Affected: build_bootc_images.py,
generate_common_versions.py, scenario.sh.
USHIFT-7169
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pre-commit.check-secrets: ENABLED
|
/test e2e-aws-tests-bootc-release-el9 |
|
scenario cc @ggiguash |
Replace el102@rpm-standard2.sh with el102@rpm-standard.sh to streamline testing for MicroShift RPM installation and removal on RHEL 10.2 VMs. The new script incorporates all necessary configurations and scenarios previously split across two files, ensuring tests run in order and with appropriate repository settings. This change enhances maintainability and reduces redundancy in the test suite. pre-commit.check-secrets: ENABLED
|
/test e2e-aws-tests-bootc-release-el9 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-aws-tests-bootc-release-el9 |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-release-arm-el10, ci/prow/e2e-aws-tests-bootc-release-arm-el9, ci/prow/e2e-aws-tests-bootc-release-el10, ci/prow/e2e-aws-tests-bootc-release-el9 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-release-arm-el10, ci/prow/e2e-aws-tests-bootc-release-el10, ci/prow/e2e-aws-tests-bootc-release-el9 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified by CI |
|
@agullon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@agullon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick release-4.22 |
|
@agullon: new pull request created: #6927 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Add a release test scenario for validating MicroShift RPM lifecycle on
a bare RHEL 10.2 VM:
el102@rpm-standard.sh— runs install, standard1, standard2, andremove test suites sequentially on a single VM (consolidated from the
split standard1/standard2 pattern used in RHEL 9 ostree scenarios)
Located under
test/scenarios-bootc/el10/releases/, adapted fromel98@rpm-standard{1,2}.shwith RHEL 10 adaptations:rhel102-installerVM image (label updated in image-installer)(subscription-manager doesn't support these repos on RHEL 10)
subscription-manager release --set 10.2TEST_EXECUTION_TIMEOUT=60m) since both suitesrun on one VM
Test plan
e2e-aws-tests-bootc-release-el10passes with new scenarioe2e-aws-tests-bootc-el9jobsJIRA: https://issues.redhat.com/browse/USHIFT-7169