CONSOLE-5021: Enable consistent-type-imports

[logonoff]

This PR enables @typescript-eslint/consistent-type-imports, then applies yarn lint --fix in a separate commit. No other changes

Summary by CodeRabbit

Release Notes

• Refactor
  • Optimized TypeScript import declarations by converting numerous runtime imports to type-only imports throughout the codebase. This improves build efficiency and reduces unnecessary runtime dependencies while maintaining all existing functionality and APIs.

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-5021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR enables @typescript-eslint/consistent-type-imports, then applies yarn lint --fix in a separate commit. No other changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/label px-approved
/label docs-approved

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-5021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR enables @typescript-eslint/consistent-type-imports, then applies yarn lint --fix in a separate commit. No other changes

Summary by CodeRabbit

Release Notes

• Refactor
• Optimized TypeScript import declarations by converting numerous runtime imports to type-only imports throughout the codebase. This improves build efficiency and reduces unnecessary runtime dependencies while maintaining all existing functionality and APIs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request systematically converts value imports to type-only imports across the console-app and console-dynamic-plugin-sdk packages. The refactor replaces regular import { TypeName } statements with import type { TypeName } for identifiers used exclusively in type positions (type annotations, generics, interfaces). Hundreds of files are updated to separate type imports from runtime value imports. Runtime behavior, public APIs, and component logic remain unchanged; this is a compile-time optimization to improve tree-shaking and clarify type boundaries in the codebase.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: enabling the ESLint rule consistent-type-imports, which aligns perfectly with the changeset's objective of converting imports throughout the codebase to use type-only imports where appropriate.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

frontend/packages/console-dynamic-plugin-sdk/src/schema/console-extensions.ts (1)

128-129: Deduplicate CreateResource in the SupportedExtension union.

CreateResource appears twice; remove one to avoid confusion and keep the union tidy.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@frontend/packages/console-dynamic-plugin-sdk/src/schema/console-extensions.ts`
around lines 128 - 129, The SupportedExtension union in console-extensions.ts
contains a duplicated member "CreateResource"; remove the extra "CreateResource"
entry from the SupportedExtension union declaration so each extension type
appears only once (locate the SupportedExtension type/union and delete the
duplicate CreateResource token).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@frontend/packages/console-app/src/components/admission-webhook-warnings/AdmissionWebhookWarningNotifications.tsx`:
- Line 3: The import shadows the global Map causing a lint error; change the
import to alias Immutable's Map (e.g., import type { Map as ImmutableMap } from
'immutable') and update all uses of Map in AdmissionWebhookWarningNotifications
(and any exported types in this file) to ImmutableMap so the global Map is not
shadowed and intent is explicit.

---

Nitpick comments:
In
`@frontend/packages/console-dynamic-plugin-sdk/src/schema/console-extensions.ts`:
- Around line 128-129: The SupportedExtension union in console-extensions.ts
contains a duplicated member "CreateResource"; remove the extra "CreateResource"
entry from the SupportedExtension union declaration so each extension type
appears only once (locate the SupportedExtension type/union and delete the
duplicate CreateResource token).

[logonoff]

changes are import-only, and don't affect API

/label plugin-api-approved acknowledge-critical-fixes-only

[vojtechszocs]

/lgtm

[logonoff]

rebase
/verified by CI

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by CI.

Details

In response to this:

rebase
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

i missed two files running yarn eslint

/verified by CI

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by CI.

Details

In response to this:

i missed two files running yarn eslint

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

rebase
/verified by CI

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by CI.

Details

In response to this:

rebase
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vojtechszocs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhadvig]

Overriding due to infra issues
/override ci/prow/e2e-gcp-console

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

Details

In response to this:

Overriding due to infra issues
/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.