Skip to content

OCPBUGS-76378: fix display of Lightspeed button#16012

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rhamilto:OCPBUGS-76378
Feb 25, 2026
Merged

OCPBUGS-76378: fix display of Lightspeed button#16012
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rhamilto:OCPBUGS-76378

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Feb 10, 2026

After

Screen.Recording.2026-02-10.at.8.49.24.AM.mov

Summary

  • Adds !important flags to background-image properties to ensure the Lightspeed logo displays correctly
  • Adds !important flags to background positioning properties for consistent styling
  • Removes right property and box-shadow that were unnecessarily duplicated

Test plan

  • Verify the Lightspeed button displays correctly in light mode
  • Verify the Lightspeed button displays correctly in dark mode (uses logo-dark.svg)
  • Verify button positioning is correct

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Style
    • Refined styling specificity for the Lightspeed popover button to ensure consistent visual presentation.
    • Updated dark theme styling for the Lightspeed component.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 10, 2026
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-76378, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Adds !important flags to background-image properties to ensure the Lightspeed logo displays correctly
  • Adds !important flags to background positioning properties for consistent styling
  • Removes right property and box-shadow that may have been interfering with proper positioning

Test plan

  • Verify the Lightspeed button displays correctly in light mode
  • Verify the Lightspeed button displays correctly in dark mode (uses logo-dark.svg)
  • Verify button positioning is correct

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 10, 2026
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-76378, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei February 10, 2026 13:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

The Lightspeed component stylesheet receives styling refinements focused on the popover button and container elements. Changes include adding !important declarations to background-image, background-position, background-repeat, and background-size properties on the popover button to enforce specificity overrides. The box-shadow declaration is removed from the button, and the right offset positioning rule is deleted. The dark theme variant updates the logo-dark.svg reference with !important. Border property formatting is normalized across related selectors. No public API surface modifications or exported declarations are altered.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the bug fix (OCPBUGS-76378) and accurately describes the primary change: fixing the display of the Lightspeed button through CSS adjustments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-76378, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

After

Screen.Recording.2026-02-10.at.8.49.24.AM.mov

Summary

  • Adds !important flags to background-image properties to ensure the Lightspeed logo displays correctly
  • Adds !important flags to background positioning properties for consistent styling
  • Removes right property and box-shadow that were unnecessarily duplicated

Test plan

  • Verify the Lightspeed button displays correctly in light mode
  • Verify the Lightspeed button displays correctly in dark mode (uses logo-dark.svg)
  • Verify button positioning is correct

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Style
  • Refined styling specificity for the Lightspeed popover button to ensure consistent visual presentation.
  • Updated dark theme styling for the Lightspeed component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2026
@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

/overrode okd-scos-images

@jhadvig
Copy link
Member

jhadvig commented Feb 18, 2026

/lgtm
/override ci/prow/okd-scos-images

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/okd-scos-images

Details

In response to this:

/lgtm
/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhamilto
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 18, 2026
@rhamilto
Copy link
Member Author

/assign @yapei

@yapei
Copy link
Contributor

yapei commented Feb 25, 2026

  • Verify the Lightspeed button displays correctly in light mode
light-mode
  • Verify the Lightspeed button displays correctly in dark mode (uses logo-dark.svg)
dark-mode
  • Verify button positioning is correct

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 25, 2026
@openshift-ci-robot
Copy link
Contributor

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

  • Verify the Lightspeed button displays correctly in light mode
light-mode
  • Verify the Lightspeed button displays correctly in dark mode (uses logo-dark.svg)
dark-mode
  • Verify button positioning is correct

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bfcdaea into openshift:main Feb 25, 2026
7 of 8 checks passed
@openshift-ci-robot
Copy link
Contributor

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-76378
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-76378 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

After

Screen.Recording.2026-02-10.at.8.49.24.AM.mov

Summary

  • Adds !important flags to background-image properties to ensure the Lightspeed logo displays correctly
  • Adds !important flags to background positioning properties for consistent styling
  • Removes right property and box-shadow that were unnecessarily duplicated

Test plan

  • Verify the Lightspeed button displays correctly in light mode
  • Verify the Lightspeed button displays correctly in dark mode (uses logo-dark.svg)
  • Verify button positioning is correct

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Style
  • Refined styling specificity for the Lightspeed popover button to ensure consistent visual presentation.
  • Updated dark theme styling for the Lightspeed component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto deleted the OCPBUGS-76378 branch February 25, 2026 17:16
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-02-26-092444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants