Skip to content

OCPBUGS-73979: Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22#432

Open
openshift-bot wants to merge 1 commit intoopenshift:mainfrom
openshift-bot:art-consistency-openshift-4.22-ose-cluster-cloud-controller-manager-operator
Open

OCPBUGS-73979: Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22#432
openshift-bot wants to merge 1 commit intoopenshift:mainfrom
openshift-bot:art-consistency-openshift-4.22-ose-cluster-cloud-controller-manager-operator

Conversation

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Jan 17, 2026

Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
ose-cluster-cloud-controller-manager-operator.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open
    a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. In cases where ART config is
    canonical, downstream builds are already being built with these changes, and merging this PR
    only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
    a grace period for the component team to align their CI with ART's configuration before it becomes
    canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be
    set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
    To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

@openshift-bot
Copy link
Author

@openshift-bot openshift-bot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. verified Signifies that the PR passed pre-merge verification criteria labels Jan 17, 2026
@openshift-bot openshift-bot changed the title Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22 OCPBUGS-73979: Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22 Jan 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2026
@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Jira Issue OCPBUGS-73979, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
ose-cluster-cloud-controller-manager-operator.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open
    a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. In cases where ART config is
    canonical, downstream builds are already being built with these changes, and merging this PR
    only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
    a grace period for the component team to align their CI with ART's configuration before it becomes
    canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be
    set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
    To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2026

@openshift-bot: This pull request references Jira Issue OCPBUGS-73979, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

Details

In response to this:

Updating ose-cluster-cloud-controller-manager-operator-container image to be consistent with ART for 4.22
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
ose-cluster-cloud-controller-manager-operator.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open
    a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. In cases where ART config is
    canonical, downstream builds are already being built with these changes, and merging this PR
    only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
    a grace period for the component team to align their CI with ART's configuration before it becomes
    canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be
    set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
    To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.22-ose-cluster-cloud-controller-manager-operator branch from b0eefa8 to 5f8ea68 Compare March 2, 2026 23:54
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 2, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Walkthrough

Go toolchain version updated from 1.24 to 1.25 across build configuration files. Both the CI operator and Dockerfile builder stage references modified to use the newer Go version. No functional logic changes.

Changes

Cohort / File(s) Summary
Go Toolchain Version Update
.ci-operator.yaml, Dockerfile
Updated Go version from 1.24 to 1.25 in build image references (CI operator build_root_image and Dockerfile builder stage).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating container images to align with ART configuration for OpenShift 4.22, which matches the file-level changes (Go 1.24 to 1.25 toolchain updates).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only .ci-operator.yaml and Dockerfile; no test files were modified, so the dynamic test name check is not applicable.
Test Structure And Quality ✅ Passed The PR modifies only build configuration files (.ci-operator.yaml and Dockerfile) to update Go toolchain versions. No test files are modified, making the test structure and quality check not applicable.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mdbooth. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
Dockerfile (1)

6-12: Consider adding a USER directive for non-root execution.

Static analysis (Trivy DS-0002) flags that no USER directive specifies a non-root user. While OpenShift's Security Context Constraints typically enforce non-root execution at runtime, explicitly setting a non-root user in the Dockerfile provides defense-in-depth.

This may be intentionally omitted if the base-rhel9 image or OpenShift platform handles user configuration. If so, this can be safely ignored.

🛡️ Optional: Add USER directive
 COPY --from=builder /go/src/github.com/openshift/cluster-cloud-controller-manager-operator/manifests manifests

 LABEL io.openshift.release.operator true
+
+USER 1001
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 6 - 12, Add an explicit non-root user in the
Dockerfile to satisfy defense-in-depth: create or switch to a non-root UID/GID
and set a USER directive near the end (after the COPY lines and before/after
LABEL as appropriate), and ensure binaries and manifests copied by COPY
(cluster-controller-manager-operator, config-sync-controllers,
azure-config-credentials-injector, manifests) are owned or accessible by that
user (adjust file ownership with chown during build or set permissive modes) so
the container runs as non-root at runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.ci-operator.yaml:
- Around line 1-4: The build_root_image tag
rhel-9-release-golang-1.25-openshift-4.22 in the CI config does not exist in the
registry; verify and either publish that tag to quay or update the tag in the
build_root_image block to an existing published tag (e.g., the previous
rhel-9-release-golang-1.24-openshift-4.22 or another available variant). Confirm
availability via the quay API or web UI, then update the tag value under
build_root_image -> tag (or coordinate with the image publisher to push the new
rhel-9-release-golang-1.25-openshift-4.22 image) and re-run CI validation.

---

Nitpick comments:
In `@Dockerfile`:
- Around line 6-12: Add an explicit non-root user in the Dockerfile to satisfy
defense-in-depth: create or switch to a non-root UID/GID and set a USER
directive near the end (after the COPY lines and before/after LABEL as
appropriate), and ensure binaries and manifests copied by COPY
(cluster-controller-manager-operator, config-sync-controllers,
azure-config-credentials-injector, manifests) are owned or accessible by that
user (adjust file ownership with chown during build or set permissive modes) so
the container runs as non-root at runtime.

ℹ️ Review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9816344 and 5f8ea68.

📒 Files selected for processing (2)
  • .ci-operator.yaml
  • Dockerfile

Comment on lines 1 to +4
build_root_image:
name: release
namespace: openshift
tag: rhel-9-release-golang-1.24-openshift-4.22
tag: rhel-9-release-golang-1.25-openshift-4.22
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Go 1.25 release date

💡 Result:

Go 1.25.0 was released on August 12, 2025. [1][2]


🏁 Script executed:

# Verify the new build root image tag exists in the OpenShift CI registry
curl -s "https://quay.io/api/v1/repository/openshift/release/tag/?specificTag=rhel-9-release-golang-1.25-openshift-4.22" | jq '.tags | length' 2>/dev/null || echo "Query failed"

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 96


🏁 Script executed:

# Search for Dockerfile references in the codebase to verify coordination claim
rg -i "dockerfile|golang.*1\.25|golang.*1\.24" --type yaml --type dockerfile -l

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 129


🏁 Script executed:

# Search for Dockerfile in the repository
fd -t f -i dockerfile

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 517


🏁 Script executed:

# Search for any mentions of golang versions across the repo
rg "golang.?1\.2[45]|GOLANG_VERSION" -i --max-count 10

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 626


Build root image tag does not appear to exist in quay.io registry.

The tag update from golang-1.24 to golang-1.25 matches the Dockerfile builder image update in the repository. However, the quay.io API query for rhel-9-release-golang-1.25-openshift-4.22 returned 0 results, suggesting this image tag may not yet be available in the registry. Verify that this image has been published and is accessible before merging.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.ci-operator.yaml around lines 1 - 4, The build_root_image tag
rhel-9-release-golang-1.25-openshift-4.22 in the CI config does not exist in the
registry; verify and either publish that tag to quay or update the tag in the
build_root_image block to an existing published tag (e.g., the previous
rhel-9-release-golang-1.24-openshift-4.22 or another available variant). Confirm
availability via the quay API or web UI, then update the tag value under
build_root_image -> tag (or coordinate with the image publisher to push the new
rhel-9-release-golang-1.25-openshift-4.22 image) and re-run CI validation.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@openshift-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 5f8ea68 link true /test unit
ci/prow/e2e-aws-ovn 5f8ea68 link true /test e2e-aws-ovn
ci/prow/level0-clusterinfra-azure-ipi-proxy-tests 5f8ea68 link false /test level0-clusterinfra-azure-ipi-proxy-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot openshift-bot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants