[release-4.22] AGENT-1544: Backport NoRegistryClusterInstall feature to release-4.22 by pawanpinjarkar · Pull Request #2930 · openshift/api

pawanpinjarkar · 2026-07-13T21:38:41Z

This patch is part of the NoRegistryClusterInstall feature backport to 4.22. It contains the following PR:

- Created machineconfiguration/v1/types_internalreleaseimage.go with v1 API - Updated compatibility level from 4 (alpha) to 1 (stable/GA) - Registered InternalReleaseImage types in v1 scheme - Created v1 integration test suite - Updated payload CRD script to use v1 instead of v1alpha1 - Generated all CRD manifests, deepcopy, and swagger docs Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Add manual CRD override to include v1alpha1 schema alongside v1 schema for InternalReleaseImage API. This allows both API versions to coexist during the graduation period, enabling gradual migration from v1alpha1 to v1 across dependent repositories. The manual override contains the complete v1alpha1 schema from the featuregated manifest, which will be merged with the v1 schema during code generation to produce a CRD that serves both versions. This addresses the review feedback to support both schemas simultaneously rather than requiring all consumers to update at once. Related: openshift#2880 (comment)

During code generation, the manifest-merge tool combines this override with the v1 schema generated from Go types to produce a final CRD that serves both versions: - v1 (storage: true): New stable API with MaxItems=5 for Conditions - v1alpha1 (storage: false): Original alpha API with MaxItems=20 for Conditions Both versions are served, but v1 is the storage version. Resources submitted via v1alpha1 are automatically converted to v1 for storage in etcd, then converted back to v1alpha1 when read, ensuring backward compatibility without requiring simultaneous updates across all consuming repositories.

openshift-merge-bot · 2026-07-13T21:38:44Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-07-13T21:38:46Z

@pawanpinjarkar: This pull request references AGENT-1500 which is a valid jira issue.

Details

In response to this:

Backport #2880 to 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-13T21:38:46Z

Hello @pawanpinjarkar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-07-13T21:38:50Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a6f477ed-4d32-4305-8dda-99e42dff016f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

pawanpinjarkar · 2026-07-13T21:56:52Z

/cc @andfasano @bfournie

andfasano · 2026-07-14T07:10:02Z

/retitle [release-4.22] AGENT-1544: Backport NoRegistryClusterInstall feature to release-4.22

openshift-ci-robot · 2026-07-14T07:10:10Z

@pawanpinjarkar: This pull request references AGENT-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Cherrypick #2880 to 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano · 2026-07-14T07:29:24Z

/hold

andfasano · 2026-07-14T07:30:13Z

/hold cancel

pawanpinjarkar · 2026-07-14T14:42:15Z

/test verify

pawanpinjarkar · 2026-07-14T15:35:04Z

/assign @yuqi-zhang

andfasano · 2026-07-14T16:01:58Z

/lgtm

openshift-merge-bot · 2026-07-14T16:03:04Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

openshift-ci · 2026-07-14T16:03:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pawanpinjarkar · 2026-07-14T18:14:32Z

/jira refresh

openshift-ci-robot · 2026-07-14T18:14:35Z

@pawanpinjarkar: This pull request references AGENT-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yuqi-zhang · 2026-07-14T19:00:06Z

In 5.0 it was a bit safer since we were doing the switch on an unreleased version, but here in 4.22 I think we would need to be a bit more careful. Deferring to @JoelSpeed on what the best path forward is (this looks like it's directly switching the payload CRD, I guess that's fine since it won't be active until we GA the featuregate?)

openshift-ci · 2026-07-14T20:59:24Z

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pawanpinjarkar · 2026-07-14T23:55:12Z

/label backport-risk-assessed

openshift-ci · 2026-07-14T23:55:47Z

@pawanpinjarkar: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

andfasano · 2026-07-15T15:20:09Z

In 5.0 it was a bit safer since we were doing the switch on an unreleased version, but here in 4.22 I think we would need to be a bit more careful. Deferring to @JoelSpeed on what the best path forward is (this looks like it's directly switching the payload CRD, I guess that's fine since it won't be active until we GA the featuregate?)

@yuqi-zhang I think it should be safe to have both v1alpha1 and v1 defined in the CRD, anyhow I understand that from a point of view of the 4.22 branch is not something strictly required.

sadasu and others added 5 commits July 13, 2026 17:05

Fix integration test

60227b2

Fix Typo

14b4f4e

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2026

openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 13, 2026

openshift-ci Bot requested review from everettraven and jkyros July 13, 2026 21:39

openshift-ci Bot requested review from andfasano and bfournie July 13, 2026 21:57

pawanpinjarkar changed the title ~~AGENT-1500: Backport 2880 to release 4.22~~ AGENT-1500: NoRegistryClusterInstall Feature Promotion (4.22 backport) Jul 13, 2026

openshift-ci Bot changed the title ~~AGENT-1500: NoRegistryClusterInstall Feature Promotion (4.22 backport)~~ [release-4.22] AGENT-1544: Backport NoRegistryClusterInstall feature to release-4.22 Jul 14, 2026

andfasano mentioned this pull request Jul 14, 2026

[release-4.22] AGENT-1545: Backport NoRegistryClusterInstall feature to release-4.22 openshift/client-go#386

Open

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2026

openshift-ci Bot assigned yuqi-zhang Jul 14, 2026

openshift-ci Bot assigned andfasano Jul 14, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2026

Uh oh!

Conversation

pawanpinjarkar commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Jul 13, 2026

Uh oh!

openshift-ci-robot commented Jul 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 13, 2026

Uh oh!

coderabbitai Bot commented Jul 13, 2026

Review skipped

Uh oh!

pawanpinjarkar commented Jul 13, 2026

Uh oh!

andfasano commented Jul 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andfasano commented Jul 14, 2026

Uh oh!

andfasano commented Jul 14, 2026

Uh oh!

pawanpinjarkar commented Jul 14, 2026

Uh oh!

pawanpinjarkar commented Jul 14, 2026

Uh oh!

andfasano commented Jul 14, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 14, 2026

Uh oh!

openshift-ci Bot commented Jul 14, 2026

Uh oh!

pawanpinjarkar commented Jul 14, 2026

Uh oh!

openshift-ci-robot commented Jul 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang commented Jul 14, 2026

Uh oh!

openshift-ci Bot commented Jul 14, 2026

Uh oh!

pawanpinjarkar commented Jul 14, 2026

Uh oh!

openshift-ci Bot commented Jul 14, 2026

Uh oh!

andfasano commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pawanpinjarkar commented Jul 13, 2026 •

edited

Loading

openshift-ci-robot commented Jul 13, 2026 •

edited by openshift-ci Bot

Loading

andfasano commented Jul 14, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jul 14, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jul 14, 2026 •

edited by openshift-ci Bot

Loading