Skip to content

CORS-4348: feature gate for EU Sovereign Cloud support#2740

Open
tthvo wants to merge 1 commit intoopenshift:masterfrom
tthvo:CORS-4348
Open

CORS-4348: feature gate for EU Sovereign Cloud support#2740
tthvo wants to merge 1 commit intoopenshift:masterfrom
tthvo:CORS-4348

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Mar 4, 2026

This PR added the feature gate for supporting EU Sovereign Cloud regions. See https://aws.amazon.com/compliance/europe-digital-sovereignty/

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2026

@tthvo: This pull request references CORS-4348 which is a valid jira issue.

Details

In response to this:

This PR added the feature gate for supporting EU Sovereign Cloud regions. See https://aws.amazon.com/compliance/europe-digital-sovereignty/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

Hello @tthvo! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Run ID: 7181eace-458a-4c7a-972c-09b1767f93a7

📥 Commits

Reviewing files that changed from the base of the PR and between dcac36b and 571e39e.

📒 Files selected for processing (10)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

📝 Walkthrough

Walkthrough

This pull request introduces a new feature gate named AWSEuropeanSovereignCloudInstall across the OpenShift codebase. Changes include adding the feature gate to the features documentation, implementing it as a public feature gate variable in the features module, and configuring its enabled/disabled status across multiple platform configurations. The feature gate is configured in development and technology preview modes, with variations in enabled/disabled states depending on deployment type (Hypershift or SelfManagedHA) and profile (Default, DevPreviewNoUpgrade, TechPreviewNoUpgrade, OKD).

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: adding a feature gate for EU Sovereign Cloud support, which aligns with all file modifications.
Description check ✅ Passed The PR description directly relates to the changeset, explaining that a feature gate for EU Sovereign Cloud support was added with a relevant AWS reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link

Review Summary by Qodo

Add feature gate for AWS European Sovereign Cloud installation

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add feature gate for AWS European Sovereign Cloud installation support
• Enable feature in DevPreview and TechPreview release channels
• Update all 8 feature gate manifest files with new gate configuration
• Document feature in features.md reference table
Diagram
flowchart LR
  A["Feature Gate Definition"] -->|"Configure"| B["AWSEuropeanSovereignCloudInstall"]
  B -->|"Enable in"| C["DevPreview & TechPreview"]
  B -->|"Disable in"| D["Default & OKD"]
  C -->|"Update"| E["8 Manifest Files"]
  E -->|"Document in"| F["features.md"]
Loading

Grey Divider

File Changes

1. features/features.go ✨ Enhancement +8/-0

Define AWSEuropeanSovereignCloudInstall feature gate

features/features.go


2. features.md 📝 Documentation +1/-0

Add feature gate to documentation table

features.md


3. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-0

Disable feature gate in Hypershift default profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml


View more (7)
4. payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable feature gate in Hypershift DevPreview profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml


5. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-0

Disable feature gate in Hypershift OKD profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml


6. payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable feature gate in Hypershift TechPreview profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml


7. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-0

Disable feature gate in SelfManagedHA default profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml


8. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable feature gate in SelfManagedHA DevPreview profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml


9. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-0

Disable feature gate in SelfManagedHA OKD profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml


10. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable feature gate in SelfManagedHA TechPreview profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml


Grey Divider

Qodo Logo

@openshift-ci openshift-ci bot requested review from JoelSpeed and everettraven March 4, 2026 02:02
@qodo-code-review
Copy link

qodo-code-review bot commented Mar 4, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@tthvo
Copy link
Member Author

tthvo commented Mar 4, 2026

/cc @patrickdillon

@JoelSpeed
Copy link
Contributor

/lgtm

/hold the EP should be merged first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift 571e39e link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview 571e39e link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-techpreview-1of2 571e39e link true /test e2e-aws-serial-techpreview-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants