NO-JIRA: Add MachineAPIMigrationVSphere feature gate for DevPreview

[AnnaZivkovic]

Introduces the MachineAPIMigrationVSphere feature gate to enable Machine API to Cluster API migration support specifically for vSphere clusters. This feature gate is currently enabled exclusively within the DevPreviewNoUpgrade feature set.

Currently, the MAPI-to-CAPI conversion logic for vSphere relies on FeatureGateClusterAPIMachineManagementVSphere. To align with the new platform-specific feature gate pattern for migrations, we are introducing this dedicated gate. Once this PR merges, we will transition the vSphere conversion logic over to use MachineAPIMigrationVSphere.

This relates to the work here #2730

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @AnnaZivkovic! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a new feature gate named MachineAPIMigrationVSphere across the codebase. A new public feature gate definition is added in the features Go package with configuration for the SPLAT Jira component and Dev Preview enablement. The feature gate is then registered in feature gate manifest files for both Hypershift and SelfManagedHA deployment configurations, with varying enabled/disabled states across Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade scenarios. A corresponding entry is added to the features documentation table.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, explaining the purpose of the new feature gate, its scope, and its relationship to existing code and future work.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: adding a new feature gate 'MachineAPIMigrationVSphere' configured for DevPreview, which is the core purpose of the PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

Review Summary by Qodo

Add MachineAPIMigrationVSphere feature gate for DevPreview

✨ Enhancement

Walkthroughs

Description

• Introduces MachineAPIMigrationVSphere feature gate for vSphere platform
• Enables Machine API to Cluster API migration support in DevPreviewNoUpgrade
• Updates feature gate manifests across multiple deployment configurations
• Registers gate with SPLAT component and jcpowermac contact person

Diagram

flowchart LR
  A["Feature Gate Definition"] -->|"Registered in"| B["features.go"]
  B -->|"Documented in"| C["features.md"]
  B -->|"Enabled in"| D["DevPreviewNoUpgrade Manifests"]
  D -->|"Includes"| E["Hypershift & SelfManagedHA Configs"]

Loading

File Changes

1. features/features.go ✨ Enhancement +7/-0

Define MachineAPIMigrationVSphere feature gate

features/features.go

---

2. features.md 📝 Documentation +1/-0

Document MachineAPIMigrationVSphere in feature matrix

features.md

---

3. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to Default manifest

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

View more (7)

4. payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to DevPreviewNoUpgrade manifest

payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml

---

5. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to OKD manifest

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

6. payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to TechPreviewNoUpgrade manifest

payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml

---

7. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to SelfManagedHA Default manifest

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

8. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to SelfManagedHA DevPreviewNoUpgrade manifest

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml

---

9. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to SelfManagedHA OKD manifest

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

10. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Add MachineAPIMigrationVSphere to SelfManagedHA TechPreviewNoUpgrade manifest

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[AnnaZivkovic]

@mdbooth Is this what you were asking for here?

[JoelSpeed]

/lgtm

/hold for @mdbooth

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[mdbooth]

/lgtm
/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@AnnaZivkovic: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	6a76ae3	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-hypershift-conformance	6a76ae3	link	true	/test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@AnnaZivkovic: This pull request explicitly references no jira issue.

Details

In response to this:

Introduces the MachineAPIMigrationVSphere feature gate to enable Machine API to Cluster API migration support specifically for vSphere clusters. This feature gate is currently enabled exclusively within the DevPreviewNoUpgrade feature set.

Currently, the MAPI-to-CAPI conversion logic for vSphere relies on FeatureGateClusterAPIMachineManagementVSphere. To align with the new platform-specific feature gate pattern for migrations, we are introducing this dedicated gate. Once this PR merges, we will transition the vSphere conversion logic over to use MachineAPIMigrationVSphere.

This relates to the work here #2730

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[AnnaZivkovic]

/retest