Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import org.openrewrite.java.search.UsesJavaVersion;
import org.openrewrite.java.tree.J;
import org.openrewrite.java.tree.JavaType;
import org.openrewrite.staticanalysis.groovy.GroovyFileChecker;
import org.openrewrite.staticanalysis.kotlin.KotlinFileChecker;

@EqualsAndHashCode(callSuper = false)
@Value
Expand All @@ -40,7 +42,11 @@ public class RenameUnderscoreIdentifier extends Recipe {
@Override
public TreeVisitor<?, ExecutionContext> getVisitor() {
return Preconditions.check(
new UsesJavaVersion<>(1, 8),
Preconditions.and(
new UsesJavaVersion<>(1, 8),
Preconditions.not(new KotlinFileChecker<>()),
Preconditions.not(new GroovyFileChecker<>())
),
new RenameIdentifierVisitor("_", "__")
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import static org.openrewrite.java.Assertions.java;
import static org.openrewrite.java.Assertions.javaVersion;
import static org.openrewrite.kotlin.Assertions.kotlin;

class RenameUnderscoreIdentifierTest implements RewriteTest {

Expand Down Expand Up @@ -273,6 +274,25 @@ void test() {
);
}

@Test
void kotlinFileNotChanged() {
rewriteRun(
spec -> spec.recipe(new RenameUnderscoreIdentifier())
.allSources(s -> s.markers(javaVersion(8))),
//language=kotlin
kotlin(
"""
class Test {
fun test() {
val pairs = listOf(1 to "a", 2 to "b")
pairs.forEach { _, _ -> println("ignored") }
}
}
"""
)
);
}

@Test
void forEachLoopVariable() {
rewriteRun(
Expand Down
Loading