Fix empty diff test failure from upstream JavaSourceSet marker updates#1057
Closed
Fix empty diff test failure from upstream JavaSourceSet marker updates#1057
Conversation
openrewrite/rewrite#7202 added JavaSourceSet marker updates to ChangeDependencyGroupIdAndArtifactId, which now modifies Java files' markers without changing text content. This causes the test framework to flag "empty diff" errors for Java source specs without explicit `after` text. Provide explicit `after` text (identical to `before`) for the Java source file in the affected test to accept the marker-only change. See openrewrite/rewrite#7349 for the upstream issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddCommonAnnotationsDependenciesTest.changeAndUpgradeDependencyIfAnnotationJsr250Present()failing with "An empty diff was generated"JavaSourceSetmarker updates toChangeDependencyGroupIdAndArtifactIdaftertext for the Java source spec to accept marker-only changesContext
Test plan
AddCommonAnnotationsDependenciesTest.changeAndUpgradeDependencyIfAnnotationJsr250Presentpasses locally