Detect indentation from existing YAML in MigrateToRules#39
Open
scuba10steve wants to merge 1 commit intomainfrom
Open
Detect indentation from existing YAML in MigrateToRules#39scuba10steve wants to merge 1 commit intomainfrom
scuba10steve wants to merge 1 commit intomainfrom
Conversation
MigrateToRules hardcoded 2-space indent increments when building the replacement rules block, producing mixed indentation on files using 4-space or other indent widths. Detect the actual indent unit by comparing the only/except entry prefix with its first sequence child prefix, falling back to 2-space when detection is not possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MigrateToRuleshardcoded 2-space indent increments when building the replacementrules:block, producing mixed indentation on files using 4-space (or other) indent widthsdetectIndentUnit()helper that compares theonly:/except:entry prefix with its first sequence child prefix to determine the actual indent increment, falling back to 2-space when detection isn't possiblecontentIndent(forwhen: neverinside sequence items) remains a fixed 2-space offset from the sequence dash, matching YAML's block sequence content alignmentTest plan
only,except, and combinedonly+except./gradlew buildpasses