Open
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses OPS-4158 by forwarding the parent process HOME environment variable into cloud CLI subprocesses so AWS/Azure/GCP tooling can resolve home-relative credential/config/cache paths reliably.
Changes:
- Forward
HOMEinto AWS CLI subprocess env when present. - Forward
HOMEinto Azure CLI subprocess env viasetEnvIfExists. - Forward
HOMEinto Google Cloud CLI and GCP auth subprocess env when present.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/openops/src/lib/google-cloud/auth.ts | Adds HOME to env passed into GCP auth/login subprocess when present. |
| packages/blocks/google-cloud/src/lib/google-cloud-cli.ts | Adds HOME to env passed into gcloud subprocess when present. |
| packages/blocks/azure/src/lib/azure-cli.ts | Forwards HOME into az subprocess env via existing env-forwarding helper. |
| packages/blocks/aws/src/lib/actions/cli/aws-cli.ts | Adds HOME to env passed into aws subprocess when present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
+43
| if (process.env['HOME']) { | ||
| envVars['HOME'] = process.env['HOME']; | ||
| } |
Comment on lines
+60
to
+62
| if (process.env['HOME']) { | ||
| envVars['HOME'] = process.env['HOME']; | ||
| } |
Comment on lines
+14
to
+16
| if (process.env['HOME']) { | ||
| envVars.HOME = process.env['HOME']; | ||
| } |
Comment on lines
23
to
+25
| setEnvIfExists(envVars, 'AZURE_CONFIG_DIR'); | ||
| setEnvIfExists(envVars, 'AZURE_EXTENSION_DIR'); | ||
| setEnvIfExists(envVars, 'HOME'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-4158.
Forward the
HOMEenvironment variable from the parent process into CLI subprocesses for AWS, Azure, and Google Cloud blocks. WithoutHOME, CLI tools can fail when resolving paths for credential caches, config files, or other home-relative resources.Changes
aws-cli.ts): ForwardHOMEif setazure-cli.ts): ForwardHOMEviasetEnvIfExistsgoogle-cloud-cli.ts): ForwardHOMEif setauth.ts): ForwardHOMEif setTesting Checklist