fix: return 404 instead of 412 when dataset not found (#1176)#1289
Open
Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Open
fix: return 404 instead of 412 when dataset not found (#1176)#1289Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1176
Problem
Currently, when requesting a dataset that does not exist, the API returns HTTP 412 (Precondition Failed). However, according to standard HTTP semantics, a missing resource should return 404 (Not Found).
Solution
Updated the dataset retrieval endpoint to return HTTP 404 when the dataset is not found.
Specifically:
returnError(111, $this->version, 404)
Why this approach
Note
Other endpoints still use HTTP 412 for similar cases. This PR focuses on the main dataset retrieval endpoint. I can extend this behavior across other endpoints if desired.