fix: prevent duplicate dataset uploads using file_id check#1288
Open
Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Open
fix: prevent duplicate dataset uploads using file_id check#1288Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Conversation
Author
|
Hi, I’ve implemented a duplicate dataset check based on This ensures that identical dataset files are not uploaded multiple times while keeping the solution minimal and consistent with the existing system. Please let me know if you’d prefer a different approach (e.g., content-based hashing) or any adjustments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent duplicate dataset uploads (#1192)
Closes #1192
Problem
Currently, the same dataset can be uploaded multiple times, resulting in duplicate entries with different dataset IDs. This leads to redundancy and inconsistency in the dataset repository.
Solution
This PR introduces a duplicate check in the
data_upload()method before inserting a new dataset.file_idalready exists.Why this approach
The system already assigns a unique
file_idto each uploaded dataset file, making it a reliable identifier for detecting duplicate uploads. This avoids the need for additional hashing or database schema changes.Result
Note
This approach detects duplicates based on identical file uploads. Further enhancements (e.g., content-based hashing) can be explored if needed.