[First Pass Feedback Requested] Create a new sample app that uses SPM#952
Open
[First Pass Feedback Requested] Create a new sample app that uses SPM#952
Conversation
Scaffold for Examples/Example_Swift-SPM: Xcode project (bundle ID net.openid.appauth.Example, no Example_Extension target), asset catalog, and placeholder ExampleApp.swift/ContentView.swift generated by Xcode. Orchestration will fill these in with AppAuth integration.
…buttons and log panel
brnnmrls
reviewed
Apr 23, 2026
| @@ -1,3 +1,6 @@ | |||
| # Unreleased | |||
| - Add SwiftUI + Swift Package Manager sample app under `Examples/Example_Swift-SPM`. | |||
Collaborator
There was a problem hiding this comment.
Can we link the PR here? Some examples are in the bullets of the previous releases.
brnnmrls
reviewed
Apr 23, 2026
| * [Example for iOS (Objective-C)](Example-iOS_ObjC/README.md) | ||
| * [Example for iOS w/ Carthage (Objective-C)](Example-iOS_ObjC-Carthage/README.md) | ||
| * [Example for iOS w/ Carthage (Swift)](Example-iOS_Swift-Carthage/README.md) | ||
| * [Example for iOS w/ SPM (SwiftUI)](Example_Swift-SPM/README.md) |
Collaborator
There was a problem hiding this comment.
For consistency, can we rename here and the folder itself to [Example for iOS w/ SPM (SwiftUI)](Example-iOS_Swift-SPM/README.md) ?
brnnmrls
reviewed
Apr 23, 2026
|
|
||
| ### Configure the Example | ||
|
|
||
| This sample reads them from an xcconfig file. Create your local override file by copying the committed defaults: |
Collaborator
There was a problem hiding this comment.
This may just be a me issue but I got confused when I read 'them' . Let's update to refer to the info above?
brnnmrls
reviewed
Apr 23, 2026
|
|
||
| if let clientId = kClientID { | ||
| self.doAuthWithAutoCodeExchange(configuration: config, clientID: clientId, clientSecret: nil) | ||
| } else { |
Collaborator
There was a problem hiding this comment.
Do we ever enter this else block? Curious because in the init() we call validateOAuthConfiguration() which asserts there is a kClientID.
brnnmrls
reviewed
Apr 23, 2026
|
|
||
| func validateOAuthConfiguration() { | ||
| assert(kClientID != nil, "Register your OIDC Client ID in Example.local.xcconfig (OIDC_CLIENT_ID).") | ||
| assert(kRedirectURI != "com.example.app:/oauth2redirect/example-provider", "Register your OIDC Redirect URI in Example.local.xcconfig (OIDC_REDIRECT_URI).") |
Collaborator
There was a problem hiding this comment.
Do we need this check? Asking since there seems to be a similar PreconditionFailure check on line 41.
brnnmrls
requested changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a simple new sample app that uses SwiftUI & SPM. Being unable to do a straightforward build of the various sample apps from the command line motivated me to do so.
I'm guessing there's more to do here - in particular, I'd love to hear if a fresh clone works.