Add SDK docs with Python and Go source-to-function examples#428
Open
welteki wants to merge 3 commits intoopenfaas:masterfrom
Open
Add SDK docs with Python and Go source-to-function examples#428welteki wants to merge 3 commits intoopenfaas:masterfrom
welteki wants to merge 3 commits intoopenfaas:masterfrom
Conversation
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
…ython index pages Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewSummary
Approval rating7/10 - Solid documentation addition with working examples, but Go code has potential nil pointer issue in readiness check Summary per fileSummary per file
Overall AssessmentThe PR adds valuable documentation for the OpenFaaS SDKs with practical examples that demonstrate common use cases for programmatic function management. The examples cover multi-tenant scenarios and CI/CD automation effectively. However, the Go code contains a potential runtime panic in the readiness check that should be addressed. Detailed ReviewDetailed Reviewdocs/sdks/index.md
docs/sdks/go/examples/source-to-function.md
docs/sdks/python/examples/source-to-function.md
docs/languages/python/examples/openfaas-api.md
mkdocs.yml
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new SDKs section covering the Python and Go SDKs. Each SDK includes a source-to-function example that walks through creating a namespace and secret, building a function image via the Function Builder API, deploying it, and invoking it.
Motivation and Context
The Python and Go SDKs lacked dedicated documentation. This gives users a reference for common use-cases such as multi-tenant platforms and CI/CD pipelines that go from source code to a running function programmatically.
How Has This Been Tested?
Both examples were run end-to-end against a live OpenFaaS Pro gateway and Function Builder, verifying a
200response with a valid token and a401with an invalid token.Types of changes
Checklist:
git commit -s