feat(github): respect Github API rate limits#5
Merged
vincentkoc merged 1 commit intoopenclaw:mainfrom May 1, 2026
Merged
Conversation
RomneyDa
changed the title
…t.do Single chokepoint Client.do now inspects the response on 403/429 and, when the headers say we're rate-limited (X-RateLimit-Remaining=0 or a Retry-After value), sleeps until the reset and retries once. The sleep honors ctx cancellation, so callers bound the wait with context.WithTimeout if they want a deadline. RequestError gains a Headers field so the retry decision can read the underlying response without re-fetching.
RomneyDa
force-pushed
the
github-rate-limit
branch
from
88ea66a to
820d7ac
Compare
RomneyDa
changed the title
RomneyDa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.donow inspects 403/429 responses; if the headers say we're rate-limited (X-RateLimit-Remaining: 0or aRetry-Aftervalue), it sleeps until the reset and retries the request once.ctxcancellation — callers bound the wait withcontext.WithTimeoutrather than a separate option.RequestErrorgains aHeadersfield so the retry decision can read the underlying response without a second fetch.Non-rate-limit 403s (permission errors) are not retried — behavior unchanged.
Test plan
go test ./...— all packages greengo vet ./...cleaninternal/github/client_test.go: 403 +X-RateLimit-Remaining: 0retried, 429 +Retry-Afterretried, ctx cancellation interrupts the retry sleep, non-rate-limit 403 not retried