fix(progress): always show at least one filled char when progress > 0#98
Merged
Conversation
When the install has many large casks, the byte-proportional bar stays near 1% during formula installs. At that percentage int(0.01 * 40) == 0, so no green characters render — the bar looks missing. Force filled=1 whenever pct>0 so the green indicator is always visible once work starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int(0.01 * 40 chars) == 0so zero green characters render and the bar looks absentpct > 0andfilledrounds to 0, clamp it to 1 so the green indicator is always visible once any work has startedformatLines()(scroll-region path) andrenderInline()(fallback path)Test plan
TestStickyProgress*suite passes (go test ./internal/ui/...)openboot installwith a config that has many large casks; green bar is visible even at 1% during formula phase