fix(sync): route brew installs through InstallWithProgress#96
Merged
Conversation
The sync flow (used by `openboot install` when a saved sync source exists) called brew.Install / brew.InstallCask directly, bypassing the StickyProgress + CacheTracker path that the wizard flow uses. The visible symptom: re-running `openboot install` showed brew's raw `Cask X # Downloading 425.8MB/ 2.9GB` output instead of the byte-proportional progress bar — even though curl|bash (first-time install) rendered it fine. Run formulae and casks through brew.InstallWithProgress as a single combined step. Tap and npm steps stay separate. Dry-run counts are preserved (per-category lengths summed on success, 0 on early error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openboot installinvoked with a saved sync source (the normal "resume last sync" path) was going throughsync.Execute→ barebrew.Install/brew.InstallCask, which pipes brew's raw non-TTY output straight through. Result: no StickyProgress bar, no byte-level cask download tracking — same binary as curl|bash but visibly different UX.brew.InstallWithProgressand renders the bar correctly. This PR unifies the two paths by routing the sync flow's formulae+casks through the same call.len(formulae) + len(casks)on success,0on early error — matches the existingexecuteSyncStepsemantic and keepstest/integration/sync_integration_test.gopassing unchanged.Test plan
go vet ./...— cleanmake test-unit— full L1 passes (includingTestIntegration_Execute_DryRun_*which assert per-step install counts)rm -f "$(brew --cache --cask <name>)"*), run./openboot installwith a sync source pointing at a config that includes that cask, confirm the StickyProgress bar fills as bytes accumulate