test(e2e): uninstall preset packages before FirstTimeUser, remove interactive skip#92
Merged
Merged
Conversation
…eractive skip - FirstTimeUser: brew uninstall the 8 minimal preset packages before running install so openboot actually installs them; previously the GHA runner had them pre-installed and newly_installed was always [] - Interactive_InstallScript: remove the brew info openboot skip guard; vmInstallViaBrew already taps and installs — fail hard if the formula is unavailable instead of silently skipping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestVM_Journey_FirstTimeUser:brew uninstallthe 8 minimal preset packages before running install so openboot actually installs them. Previouslynewly installed formulae: []every run because the GHA runner image has them pre-installed.TestVM_Interactive_InstallScript: remove thebrew info openbootskip guard.vmInstallViaBrewalready taps and installs — if the formula is unavailable the test now fails hard instead of silently skipping.Test plan
vm-e2e-spikemanually and confirmnewly installed formulae:is non-empty in FirstTimeUser logs, and Interactive no longer shows SKIP