test(e2e): fix trivial vm assertions and force fresh oh-my-zsh installs#91
Merged
Merged
Conversation
- FirstTimeUser: capture brew list before/after install, assert all minimal preset formulae are brew-managed after; log newly installed for debugging - Sync_Shell tests: rm -rf ~/.oh-my-zsh before installOhMyZsh so the install script actually runs instead of hitting the idempotency guard - CaptureShell: assert snapshot JSON contains the configured theme and plugins, not just that output is non-empty - Edge_ShellActuallyWorks: rm -rf ~/.oh-my-zsh so openboot shell install exercises the real code path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestVM_Journey_FirstTimeUser: capturebrew listbefore/after install; assert all minimal preset formulae (jq,ripgrep,fd,bat,fzf,htop,tree,gh) are brew-managed after install; log newly installed diff for debugging. Previously the test passed trivially on GHA runners that have these tools pre-installed.TestVM_Sync_Shell_CaptureShell/TestVM_Sync_Shell_NoPanic:rm -rf ~/.oh-my-zshbeforeinstallOhMyZshso the install script actually runs instead of hitting the idempotency guard.TestVM_Sync_Shell_CaptureShell: assert snapshot JSON contains the configured theme (agnoster) and plugin (docker), not just that output is non-empty.TestVM_Edge_ShellActuallyWorks:rm -rf ~/.oh-my-zshso openboot's shell install exercises the real code path.Test plan