Refresh callable Azure API keys before requests#2992
Open
LittleChenLiya wants to merge 3 commits intoopenai:mainfrom
Open
Refresh callable Azure API keys before requests#2992LittleChenLiya wants to merge 3 commits intoopenai:mainfrom
LittleChenLiya wants to merge 3 commits intoopenai:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a67dbb199
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Azure clients so callable
api_keyproviders are refreshed before each request.AzureOpenAIandAsyncAzureOpenAIoverride_prepare_options()to add Azure-specific auth headers, but they were not refreshing callable API keys before setting theapi-keyheader. As a result, dynamic API key providers were not applied to requests or retries.Changes
AzureOpenAI._prepare_options()AsyncAzureOpenAI._prepare_options()api_keyproviders across retriesTesting
python -m pytest tests/lib/test_azure.py -n 0python -m pytest tests/test_client.py -k "api_key_before_after_refresh or api_key_refresh_on_retry or bearer_token_refresh_async" -n 0Closes #2626