Skip malformed session history items#3578
Open
White-Mouse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shared session-history admission helper for decoded response input items and applies it across the built-in plaintext session backends. JSON-valid scalar/list rows are now skipped the same way invalid JSON rows are skipped instead of being replayed as model input history.
This covers SQLiteSession, AsyncSQLiteSession, RedisSession, DaprSession, SQLAlchemySession, and MongoDBSession.
Why
Built-in session backends store response input items as JSON rows and later replay decoded rows into Runner model input. Invalid JSON rows were already ignored, but a row that decoded successfully to a JSON scalar or array could still be returned as session history. Persistent-store rows should be admitted only when they are shaped like response input item objects.
Tests
uv run --extra sqlalchemy pytest tests/memory tests/extensions/memory -quv run ruff check src/agents/memory/session.py src/agents/memory/sqlite_session.py src/agents/extensions/memory/async_sqlite_session.py src/agents/extensions/memory/redis_session.py src/agents/extensions/memory/dapr_session.py src/agents/extensions/memory/sqlalchemy_session.py src/agents/extensions/memory/mongodb_session.py tests/memory/test_session.py tests/extensions/memory/test_async_sqlite_session.py tests/extensions/memory/test_redis_session.py tests/extensions/memory/test_dapr_session.py tests/extensions/memory/test_mongodb_session.py tests/extensions/memory/test_sqlalchemy_session.pyuv run ruff format --check src/agents/memory/session.py src/agents/memory/sqlite_session.py src/agents/extensions/memory/async_sqlite_session.py src/agents/extensions/memory/redis_session.py src/agents/extensions/memory/dapr_session.py src/agents/extensions/memory/sqlalchemy_session.py src/agents/extensions/memory/mongodb_session.py tests/memory/test_session.py tests/extensions/memory/test_async_sqlite_session.py tests/extensions/memory/test_redis_session.py tests/extensions/memory/test_dapr_session.py tests/extensions/memory/test_mongodb_session.py tests/extensions/memory/test_sqlalchemy_session.pyuv run python -m py_compile src/agents/memory/session.py src/agents/memory/sqlite_session.py src/agents/extensions/memory/async_sqlite_session.py src/agents/extensions/memory/redis_session.py src/agents/extensions/memory/dapr_session.py src/agents/extensions/memory/sqlalchemy_session.py src/agents/extensions/memory/mongodb_session.py tests/memory/test_session.py tests/extensions/memory/test_async_sqlite_session.py tests/extensions/memory/test_redis_session.py tests/extensions/memory/test_dapr_session.py tests/extensions/memory/test_mongodb_session.py tests/extensions/memory/test_sqlalchemy_session.pygit diff --check