fix: gate remote-mount edit guidance by mode#3423
Conversation
2736b84 to
ef469b6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2736b84b00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ef469b6 to
ae4774f
Compare
|
Updated this to gate remote-mount edit guidance by mount mode. Direct Added regression coverage for read-only-only, read+write-only, mixed remote mount manifests, and runtime policy injection. Checked locally with:
|
Build the remote-mount edit guidance from the actual mount modes in the manifest. Read+write mounts still get direct apply_patch and shell copy-back guidance, while read-only mounts explicitly avoid both in-place edits and write-back. This keeps the generated policy consistent for read-only-only manifests and makes mixed read-only/read+write manifests unambiguous.
ae4774f to
b9a3485
Compare
Summary
apply_patchand shell copy-back guidance only when at least one remote mount is read+write.apply_patch, and not to write edited files back to those paths.Test plan
UV_CACHE_DIR=/tmp/uv-cache UV_PROJECT_ENVIRONMENT=/tmp/openai-pr3423-venv UV_PYTHON=3.12.13 make formatUV_CACHE_DIR=/tmp/uv-cache UV_PROJECT_ENVIRONMENT=/tmp/openai-pr3423-venv UV_PYTHON=3.12.13 make lintUV_CACHE_DIR=/tmp/uv-cache UV_PROJECT_ENVIRONMENT=/tmp/openai-pr3423-venv UV_PYTHON=3.12.13 make typecheckUV_CACHE_DIR=/tmp/uv-cache UV_PROJECT_ENVIRONMENT=/tmp/openai-pr3423-venv UV_PYTHON=3.12.13 make testsIssue number
N/A
Checks
make lintandmake format