fix: redact mountpoint credentials in sandbox mount errors#3421
Closed
matthewflint wants to merge 1 commit into
Closed
fix: redact mountpoint credentials in sandbox mount errors#3421matthewflint wants to merge 1 commit into
matthewflint wants to merge 1 commit into
Conversation
Keep the executable mount-s3 command unchanged, but redact AWS credential environment variables when reporting MountCommandError so failures do not expose secrets.
matthewflint
force-pushed
the
mflint/sandbox-redact-mountpoint-credentials
branch
from
a6fe294 to
1bc0593
Compare
Member
|
Thanks for sharing this. #3429 resolved the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mount-s3shell command unchanged for execution.MountCommandErrorso AWS access key, secret key, and session token are not exposed when a mount fails.Why
MountpointMountPattern.apply()currently prefixesmount-s3with AWS credential environment variables. On failure it passes that full command intoMountCommandError, which can leak credentials into exceptions, test logs, or user-visible diagnostics.Testing
uv run pytest tests/sandbox/test_mount_patterns.pyuv run ruff check src/agents/sandbox tests/sandboxuv run pyright