fix: reject external symlink targets during hydrate#3094
Open
Aphroq wants to merge 1 commit intoopenai:mainfrom
Open
fix: reject external symlink targets during hydrate#3094Aphroq wants to merge 1 commit intoopenai:mainfrom
Aphroq wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request rejects tar symlink targets that point outside the extracted archive root during workspace hydrate and restore flows.
tar_utilsfor hydrate paths while keeping the general tar helpers' default behavior unchangedCompatibility change: If a user’s sandbox snapshot/workspace contains symlinks intentionally pointing to system paths (e.g.,
/usr/bin/python, certain toolchain paths, or host mount points), then after hydrate/restore these will change from “restorable” to “refused to restore.”Test plan
uv run pytest tests/sandbox/test_tar_utils.py tests/sandbox/test_extract.py tests/extensions/sandbox/test_vercel.pybash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3093
Checks
make lintandmake format