Skip to content

windows: verify raw pipe command parity#29985

Draft
anp-oai wants to merge 1 commit into
codex/pr3-06-raw-pipe-launcherfrom
codex/pr3-07-command-parity
Draft

windows: verify raw pipe command parity#29985
anp-oai wants to merge 1 commit into
codex/pr3-06-raw-pipe-launcherfrom
codex/pr3-07-command-parity

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Intent

The raw Windows launcher changes a compatibility-sensitive process boundary. The stack should only complete after its observable command behavior matches the previous Tokio path across representative Windows cases.

Implementation

  • Add a table-driven test-local Tokio reference launcher.
  • Compare exit status, stdout, and stderr between Tokio and the raw launcher.
  • Cover closed stdin, separate output streams, native exit code 37, Unicode environment and cwd values, tricky quoting and trailing backslashes, spaced executable paths, child PATH lookup, and .cmd/.bat dispatch.

Manual validation

  • Cross-compiled the complete codex-utils-pty Windows test target with cargo +1.95.0 check --target x86_64-pc-windows-msvc -p codex-utils-pty --tests.

Stack

1. job primitives2. local ConPTY3. restricted sessions4. elevated runner5. command preparation6. raw pipe launcher7. command parity

@anp-oai anp-oai force-pushed the codex/pr3-06-raw-pipe-launcher branch from 46dee87 to d891bf2 Compare June 25, 2026 04:26
@anp-oai anp-oai force-pushed the codex/pr3-07-command-parity branch from b22517d to 5b56447 Compare June 25, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant