Simplify Prometheus metric collection#5368
Closed
09Catho wants to merge 1 commit into
Closed
Conversation
Signed-off-by: 09Catho <ashketchume45@gmail.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Prometheus exporter’s collection pipeline by replacing the internal queued MetricsData buffering with a single “current snapshot”, and translating that snapshot directly during Prometheus collect().
Changes:
- Replace
_CustomCollector’sdequeof pendingMetricsDatawith a single_metrics_datasnapshot. - Simplify
collect()to translate a single snapshot and yield once per scrape. - Preserve cached
target_infocreation behavior (created once and reused).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+337
to
+338
| if self._metrics_data is None: | ||
| return |
Contributor
|
Closing this PR as already addressed by #5123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2500.
Testing
Note: I also ran test_entrypoints.py with local PYTHONPATH; the entrypoint import test failed because the package entry point is not installed in this ad hoc environment, while the other 3 tests passed.