Skip to content

Use a covariant type for detectors argument #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickstenning wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use a covariant type for detectors argument #5135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#5120](https://github.com/open-telemetry/opentelemetry-python/pull/5120))
- Add WeaverLiveCheck test util
([#5088](https://github.com/open-telemetry/opentelemetry-python/pull/5088))
- Fix incorrect type annotation on `detectors` parameter of `get_aggregated_resources`
([#5135](https://github.com/open-telemetry/opentelemetry-python/pull/5135))

## Version 1.41.0/0.62b0 (2026-04-09)

Expand Down
3 changes: 2 additions & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
import socket
import sys
import typing
from collections.abc import Sequence
from json import dumps
from os import environ
from types import ModuleType
Expand Down Expand Up @@ -517,7 +518,7 @@ def detect(self) -> "Resource":


def get_aggregated_resources(
detectors: typing.List["ResourceDetector"],
detectors: Sequence["ResourceDetector"],
initial_resource: typing.Optional[Resource] = None,
timeout: int = 5,
) -> "Resource":
Expand Down
Loading