feat(config): add resource and propagator creation from declarative config#4979
Open
MikeGoldsmith wants to merge 7 commits intoopen-telemetry:mainfrom
Open
feat(config): add resource and propagator creation from declarative config#4979MikeGoldsmith wants to merge 7 commits intoopen-telemetry:mainfrom
MikeGoldsmith wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
Implements create_resource() and create_propagator()/configure_propagator() for the declarative file configuration. Resource creation does not read OTEL_RESOURCE_ATTRIBUTES or run any detectors (matches Java/JS SDK behavior). Propagator configuration always calls set_global_textmap to override Python's default tracecontext+baggage, setting a noop CompositePropagator when no propagator is configured. Assisted-by: Claude Sonnet 4.6
Assisted-by: Claude Sonnet 4.6
- _resource.py: refactor _coerce_attribute_value to dispatch table to avoid too-many-return-statements; fix short variable names k/v -> attr_key/attr_val; fix return type of _sdk_default_attributes to dict[str, str] to satisfy pyright - _propagator.py: rename short variable names e -> exc, p -> propagator - test_resource.py: move imports to top level; split TestCreateResource (25 methods) into three focused classes to satisfy too-many-public-methods - test_propagator.py: add pylint disable for protected-access Assisted-by: Claude Sonnet 4.6
pmcollins
reviewed
Mar 13, 2026
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_resource.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_resource.py
Outdated
Show resolved
Hide resolved
- replace _sdk_default_attributes() with _DEFAULT_RESOURCE from resources module - move _coerce_bool into dispatch tables for both scalar and array bool types, fixing a bug where bool_array with string values like "false" would coerce incorrectly via plain bool() (non-empty string -> True) - add test for bool_array with string values to cover the bug Assisted-by: Claude Sonnet 4.6
… into mike/config-resource-propagator
herin049
reviewed
Mar 16, 2026
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_resource.py
Outdated
Show resolved
Hide resolved
| seen_types.add(type(propagator)) | ||
| propagators.append(propagator) | ||
|
|
||
| # Process structured composite list |
Contributor
There was a problem hiding this comment.
Should the structured propagator list also support entrypoints?
Member
Author
There was a problem hiding this comment.
The structured composite list is intentionally limited to the four types defined in the config schema (tracecontext, baggage, b3, b3multi) — the schema enforces maxProperties: 1 with fixed property names, so there's no way to specify an unknown third-party propagator via that path. For anything outside those four, composite_list (the comma-separated string) is the right mechanism, and that does use entry points. So I don't think we need entry point support in the structured path.
10 tasks
…erge - collapse _SCALAR_COERCIONS and _ARRAY_COERCIONS into a single _COERCIONS dict using an _array() factory, reducing _coerce_attribute_value to two lines - process attributes_list before attributes so explicit attributes naturally overwrite list entries without needing an explicit guard Assisted-by: Claude Sonnet 4.6
10 tasks
pmcollins
approved these changes
Mar 16, 2026
Member
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
Thanks, LGTM once suggestions are addressed (I added a typing suggestion).
| return bool(value) | ||
|
|
||
|
|
||
| def _array(coerce: object) -> object: |
Member
There was a problem hiding this comment.
Suggested change
| def _array(coerce: object) -> object: | |
| def _array(coerce: Callable) -> Callable: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements step 3 of the declarative configuration work (see below), resource and propagator creation from a parsed config file.
Adds:
create_resource(config)— builds an SDKResourcefrom the declarative config model without readingOTEL_RESOURCE_ATTRIBUTESor running any resource detectors (matches Java/JS SDK behavior). Starts from SDK telemetry defaults (telemetry.sdk.*), mergesattributes(withAttributeTypecoercion) andattributes_list(URL-decoded, lower priority), and addsservice.name=unknown_serviceif not specified.create_propagator(config)— builds aCompositePropagatorfrom the config'scompositelist and/orcomposite_liststring. Deduplicates by propagator type. Returns an emptyCompositePropagator(noop) when no propagator is configured.configure_propagator(config)— callsset_global_textmapto override Python's default env-var-based propagator setup.ConfigurationErrormoved to_exceptions.pyto break a circular import introduced whenfile/__init__.pyre-exports the new functions.All functions are exported from
opentelemetry.sdk._configuration.file.Type of change
How Has This Been Tested?
43 new unit tests covering:
AttributeTypecoercions (string, bool, int, double, and array variants)attributes_listparsing: priority vs explicit attributes, URL decoding,=in values, invalid pairsschema_urlpassthroughOTEL_RESOURCE_ATTRIBUTESenv var is NOT readtracecontext,baggage,b3,b3multi)composite+composite_listmerging and deduplicationnoneand empty entries incomposite_listskippedConfigurationErrorconfigure_propagatorcallsset_global_textmapDoes This PR Require a Contrib Repo Change?
Checklist:
Assisted-by: Claude Sonnet 4.6