Fix/check links workflow condition#4978
Open
Manvi2402 wants to merge 5 commits intoopen-telemetry:mainfrom
Open
Fix/check links workflow condition#4978Manvi2402 wants to merge 5 commits intoopen-telemetry:mainfrom
Manvi2402 wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
lzchen
reviewed
Mar 13, 2026
| @@ -3,45 +3,45 @@ on: | |||
| push: | |||
| branches: [ main ] | |||
Contributor
There was a problem hiding this comment.
Nit: Should we add paths to on push as well?
Author
There was a problem hiding this comment.
I'll add paths to push as well to keep it consistent.
lzchen
reviewed
Mar 13, 2026
.github/workflows/check-links.yml
Outdated
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 |
Contributor
There was a problem hiding this comment.
Do we still need to fetch the entire history now that we are using tj-actions/changed-files?
Author
There was a problem hiding this comment.
You're right! Since we're now using tj-actions/changed-files, fetch-depth: 0 is no longer needed. I'll remove it.
…om/Manvi2402/opentelemetry-python into fix/check-links-workflow-condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the check-links CI workflow by:
files are changed
tj-actions/changed-files@v46
Fixes #4943
Type of change
How Has This Been Tested?
Workflow changes reviewed against existing CI configuration.
Based on the approach from #4968 by @emdneto
Does This PR Require a Contrib Repo Change?
Checklist: