Enforce OTLP request size limits#8446
Open
ADITYA-CODE-SOURCE wants to merge 1 commit into
Open
Conversation
Contributor
|
ADITYA-CODE-SOURCE
force-pushed
the
issue-8444-otlp-message-limits
branch
from
280870d to
6720aae
Compare
jkwatson
reviewed
Jun 3, 2026
|
|
||
| private static final String DEFAULT_ENDPOINT = "http://localhost:4318/v1/traces"; | ||
| private static final MemoryMode DEFAULT_MEMORY_MODE = MemoryMode.REUSABLE_DATA; | ||
| private static final long DEFAULT_MAX_REQUEST_BODY_SIZE = 64 * 1024L * 1024L; |
Contributor
There was a problem hiding this comment.
nit: can we add _BYTES to the end of this constant
jkwatson
reviewed
Jun 3, 2026
| /** | ||
| * Sets the maximum OTLP HTTP request body size in bytes. If unset, defaults to 64 MiB. | ||
| */ | ||
| public OtlpHttpLogRecordExporterBuilder setMaxRequestBodySize(long maxRequestBodySize) { |
Contributor
There was a problem hiding this comment.
nit: can we add Bytes to the end of the parameter name (here and the other public API surfaces)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8444.
Why
opentelemetry-proto#782now recommends that OTLP exporters enforce configurable outbound request/message size limits.What
docs/apidiffs/current_vs_latest/opentelemetry-exporter-otlp.txtfor the new public builder methodsTesting
I was not able to complete local Gradle verification on this Windows machine because Gradle / the Kotlin compiler daemon repeatedly failed to start due to paging-file / metaspace limits before compilation finished. The changes are pushed for CI verification.