Fix PeriodicMetricReader shutdown race losing final metrics#8299
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Apr 16, 2026
Merged
Fix PeriodicMetricReader shutdown race losing final metrics#8299jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
When a periodic export is in-flight during shutdown, doRun() sees exportAvailable=false and drops the final collection. Then exporter.shutdown() cancels the in-flight export via cancelAll(). Fix: wait for any in-flight flush to complete before the final doRun() in shutdown(). Track the in-flight flush via a volatile flushInProgress field set at the start of each doRun() cycle.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8299 +/- ##
=========================================
Coverage 90.25% 90.26%
- Complexity 7683 7684 +1
=========================================
Files 850 850
Lines 23190 23193 +3
Branches 2353 2353
=========================================
+ Hits 20930 20935 +5
+ Misses 1533 1532 -1
+ Partials 727 726 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a periodic export is in-flight during shutdown, doRun() sees exportAvailable=false and drops the final collection. Then exporter.shutdown() cancels the in-flight export via cancelAll().
Fix: wait for any in-flight flush to complete before the final doRun() in shutdown(). Track the in-flight flush via a volatile flushInProgress field set at the start of each doRun() cycle.