Skip to content

fix examples/configuration#4041

Merged
lalitb merged 2 commits intoopen-telemetry:mainfrom
rishitha957:fix_with_config
May 1, 2026
Merged

fix examples/configuration#4041
lalitb merged 2 commits intoopen-telemetry:mainfrom
rishitha957:fix_with_config

Conversation

@rishitha957
Copy link
Copy Markdown
Contributor

@rishitha957 rishitha957 commented Apr 30, 2026

Changes

cmake with WITH_CONFIGURATION flag would break build now, as target link library is not recognizing private keyword

To reproduce this issue, run cmake -S . -B build -G Ninja -DWITH_CONFIGURATION=1 && ninja -C build

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@rishitha957 rishitha957 requested a review from a team as a code owner April 30, 2026 21:14
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 30, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

Comment thread examples/configuration/CMakeLists.txt Outdated
target_link_libraries(
example_yaml ${CMAKE_THREAD_LIBS_INIT}
PRIVATE common_metrics_foo_library
example_yaml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
example_yaml
example_yaml
example_yaml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is trailing whitespace after example_yaml, which needs to be fixed for CI to pass.

Copy link
Copy Markdown
Contributor Author

@rishitha957 rishitha957 May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh fixed the format now, thanks! not sure why it says merge blocking still .. should I wait for the CI? (but that seems to be stuck on action required: awaiting approval from maintainers actions

Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.07%. Comparing base (dbf6567) to head (183379d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4041      +/-   ##
==========================================
+ Coverage   82.06%   82.07%   +0.02%     
==========================================
  Files         385      385              
  Lines       15891    15891              
==========================================
+ Hits        13039    13041       +2     
+ Misses       2852     2850       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>
@lalitb lalitb enabled auto-merge (squash) May 1, 2026 19:25
@lalitb lalitb merged commit d2be704 into open-telemetry:main May 1, 2026
68 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants