Skip to content

fix: noexcept for Observer #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbarker merged 2 commits into from
May 2, 2026
+23 −0
Merged

fix: noexcept for Observer #4039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9012324
fix: noexcept for Observer
proost Apr 30, 2026
2535646
Merge branch 'main' into fix-avoid-exception-observerresult
dbarker May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions sdk/include/opentelemetry/sdk/metrics/observer_result.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include "opentelemetry/common/attribute_value.h"
#include "opentelemetry/common/key_value_iterable.h"
#include "opentelemetry/common/macros.h"
#include "opentelemetry/metrics/observer_result.h"
#include "opentelemetry/nostd/string_view.h"
#include "opentelemetry/sdk/metrics/state/attributes_hashmap.h"
Expand Down Expand Up @@ -34,15 +35,37 @@ class ObserverResultT final : public opentelemetry::metrics::ObserverResultT<T>
~ObserverResultT() override = default;

void Observe(T value) noexcept override
#if OPENTELEMETRY_HAVE_EXCEPTIONS
try
#endif
{
data_[MetricAttributes{{}, attributes_processor_}] = value;
}
#if OPENTELEMETRY_HAVE_EXCEPTIONS
catch (...)
{
// Silently drop the measurement; per opentelemetry-cpp guidance (PR #3964),
// exceptions in noexcept API/SDK code must not log or abort.
return;
}
#endif

void Observe(T value, const opentelemetry::common::KeyValueIterable &attributes) noexcept override
#if OPENTELEMETRY_HAVE_EXCEPTIONS
try
#endif
{
data_[MetricAttributes{attributes, attributes_processor_}] =
value; // overwrites the previous value if present
}
#if OPENTELEMETRY_HAVE_EXCEPTIONS
catch (...)
{
// Silently drop the measurement; per opentelemetry-cpp guidance (PR #3964),
// exceptions in noexcept API/SDK code must not log or abort.
return;
}
#endif

const std::unordered_map<MetricAttributes, T, AttributeHashGenerator> &GetMeasurements()
{
Expand Down
Loading