allow setting Onyx::SQL::Repository#db with DB::Transaction instances#107
Open
repomaa wants to merge 1 commit intoonyxframework:masterfrom
Open
allow setting Onyx::SQL::Repository#db with DB::Transaction instances#107repomaa wants to merge 1 commit intoonyxframework:masterfrom
Onyx::SQL::Repository#db with DB::Transaction instances#107repomaa wants to merge 1 commit intoonyxframework:masterfrom
Conversation
Member
|
Hey, @repomaa, welcome back 😉 Would you mind adding some specs? |
repomaa
force-pushed
the
topic/transaction_assignment
branch
from
c320430 to
fe00e3a
Compare
Author
|
Hey @vladfaust o/ |
repomaa
force-pushed
the
topic/transaction_assignment
branch
from
fe00e3a to
7480f09
Compare
vladfaust
requested changes
Jul 25, 2019
repomaa
force-pushed
the
topic/transaction_assignment
branch
from
7480f09 to
5b9e7d4
Compare
repomaa
force-pushed
the
topic/transaction_assignment
branch
from
5b9e7d4 to
0a154fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #97