Handle correct response code for token expired error#875
Open
philipgough wants to merge 1 commit intoobservatorium:mainfrom
Open
Handle correct response code for token expired error#875philipgough wants to merge 1 commit intoobservatorium:mainfrom
philipgough wants to merge 1 commit intoobservatorium:mainfrom
Conversation
philipgough
force-pushed
the
oidc-check
branch
2 times, most recently
from
31f241e to
478b82c
Compare
philipgough
force-pushed
the
oidc-check
branch
from
478b82c to
f0eb32f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your SLO depend on HTTP status code from metrics from this project, a disruptive user has the opportunity to generate 5xx responses with an expired token and burn your budget.
This change makes use of the provided error in
github.com/coreos/go-oidc/v3/oidcto allow us to return a 4xx response in such cases.