Draft
Conversation
Since we want to support brushing histograms, we needed two additional features: * an **interval** option for snapping the brush on gesture end. * support for X1/X2 channels in renderFilter, for rect marks. (This will require some work to merge with #2363)
# Conflicts: # src/interactions/brush.js
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # src/interactions/brush.js
# Conflicts: # src/interactions/brush.d.ts # src/interactions/brush.js # test/plots/brush.ts
# Conflicts: # docs/interactions/brush.md # src/interactions/brush.d.ts # test/brush-test.ts
Draft
to avoid the context line connecting through the brush, we split the data into several runs, broken when a point is filtered out. (typically on a line chart, this makes one line on the lhs of the brush, the other on the rhs)
this inset is making it possible to select values that are ON the edge, but it's nicer to the eye to not have it where it's not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch merges all the branches that depend on
fil/brush-dataless(#2360), fixes the conflicts, and changes the tests and examples of cross-facet brushing to a timelineEnregistrement.de.l.ecran.2026-02-20.a.16.26.58.mov
(This branch combines everything, so while it may be better for testing, it's probably not as good for reviewing.)