feat(app-shell): honor dropdown userFilters on object list views (#2338)#2341
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
The object default list view ("views" mode) hard-coded
`userFilters: undefined` in `ObjectView.renderListView`, dropping the
Airtable-style quick-filter chips even when the backend shipped them.
`<ListView>` / `<UserFilters>` already render dropdown chips — only this
app-shell layer blocked them.
- ObjectView: pass `viewDef.userFilters ?? listSchema.userFilters`
through when `element !== 'tabs'` and no `tabs` array; `tabs` stays
suppressed (it would collide with the ViewTabBar) and `quickFilters`
stays suppressed entirely.
- warnSuppressedListNav: warn only for `quickFilters` and `tabs`-mode
userFilters; a `dropdown` userFilters is no longer "suppressed".
Companion framework spec change (opens the schema): objectstack-ai/framework#2679.
Verified end-to-end on the app-showcase Projects default list view.
…iews, tabs page-only (#2338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2338
问题
对象的默认列表视图("views" 模式)无法显示 Airtable 风格快捷筛选胶囊(Status / Health 这类下拉)。即使后端下发了
userFilters,ObjectView.renderListView也会在运行时硬编码userFilters: undefined(ADR-0053 phase-4 一刀切抑制)丢弃它。而<ListView>/<UserFilters>(plugin-list)本身早已具备渲染 dropdown 胶囊的能力——只差 app-shell 这一层放行。方案(ADR-0047 修订:dropdown 放行,tabs 保持页面专属)
ObjectView.tsx:把userFilters: undefined改为透传——当element !== 'tabs'且未携带tabs时传viewDef.userFilters ?? listSchema.userFilters,否则undefined。tabs仍抑制(会与 ViewTabBar 冲突),quickFilters仍抑制。warnSuppressedListNav.ts:只对quickFilters和tabs模式的userFilters告警;dropdown 不再视为"被抑制"。更新文案。warnSuppressedListNav.test.ts。测试
warnSuppressedListNav.test.ts(5 passed)。端到端生效依赖 framework spec 放开对象列表视图的
userFilters:objectstack-ai/framework#2683(issue #2679)。