Open
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
matevz
force-pushed
the
matevz/fix/no-localnet-sgxs
branch
from
aca3817 to
dea0166
Compare
Compiling SGXS flavors of ROFLs in unsafe mode does not really make sense. Instead put a dummy .sgxs file so the enclave metadata can still be computed.
matevz
force-pushed
the
matevz/fix/no-localnet-sgxs
branch
from
dea0166 to
d17d10f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling SGXS + unsafe mode does not really make sense. It also fails, if you're depending on libraries that require primitives inaccessible from SGX. Instead put a dummy .sgxs file in .orc besides .elf so the enclave metadata can still be computed.
Related: oasisprotocol/oasis-sdk#2430