Skip to content

feat(base16): add support for blink.cmp#2411

Open
kristijanhusak wants to merge 1 commit into
nvim-mini:mainfrom
kristijanhusak:base16-add-blink
Open

feat(base16): add support for blink.cmp#2411
kristijanhusak wants to merge 1 commit into
nvim-mini:mainfrom
kristijanhusak:base16-add-blink

Conversation

@kristijanhusak
Copy link
Copy Markdown

Add support for blink.cmp to base16.
Used same colors as for nvim-cmp, just adjusted the hl group names.

@echasnovski
Copy link
Copy Markdown
Member

Thanks for the PR!

This is a bit too big of an addition. Looking at 'nvim-cmp', I'd say that adding explicit override for every Kind is a bit too much also.

As I don't use 'blink.cmp', could you please post a screenshot of it using these highlights before and after changes from this PR?

@kristijanhusak
Copy link
Copy Markdown
Author

This is a bit too big of an addition. Looking at 'nvim-cmp', I'd say that adding explicit override for every Kind is a bit too much also.

I'm not sure what you mean. nvim-cmp is already in the code. I just followed the same structure while adjusting the hl group names.

As I don't use 'blink.cmp', could you please post a screenshot of it using these highlights before and after changes from this PR?

Here are a couple of screenshots. It doesn't show all the colors, but gives the idea how it looks.

screenshot_2026_05_13_11_48_14 screenshot_2026_05_13_11_46_54

@echasnovski
Copy link
Copy Markdown
Member

I'm not sure what you mean. nvim-cmp is already in the code. I just followed the same structure while adjusting the hl group names.

I meant that if I were to add the 'nvim-cmp' integration now, it would probably not have all the XxxKind groups.

As I don't use 'blink.cmp', could you please post a screenshot of it using these highlights before and after changes from this PR?

Here are a couple of screenshots. It doesn't show all the colors, but gives the idea how it looks.

They don't look much different. Those are both "after", right?

@kristijanhusak
Copy link
Copy Markdown
Author

I meant that if I were to add the 'nvim-cmp' integration now, it would probably not have all the XxxKind groups.

I can move things around if you have some suggestions. I think this is fine since users can enable/disable specific integrations.

They don't look much different. Those are both "after", right?

Ah yeah, right. Here's the comparison:

before after
screenshot_2026_05_13_12_09_04 screenshot_2026_05_13_11_48_14
screenshot_2026_05_13_12_08_42 screenshot_2026_05_13_11_46_54

@echasnovski
Copy link
Copy Markdown
Member

I can move things around if you have some suggestions. I think this is fine since users can enable/disable specific integrations.

No need, thanks. It is mostly me thinking if adding all these XxxKind groups is worth it for 'blink.cmp'.

Ah yeah, right. Here's the comparison:

Thanks, that's useful! The obvious usability issue is not showing matched characters. The not colored kinds are kind of okay.

I'll need a bit more time to think about this.

@kristijanhusak
Copy link
Copy Markdown
Author

if adding all these XxxKind groups is worth it for 'blink.cmp'

I'd say that blink.cmp is more popular nowadays than nvim-cmp, so I think it's worth having both of these.


Note that I'm using a custom layout for the completion popup. This is how it looks with default layout:

before after
screenshot_2026_05_13_12_51_28 screenshot_2026_05_13_12_49_18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants