This repository was archived by the owner on Oct 13, 2021. It is now read-only.
[WIP] Make <CR> "extensible" for other plugins.#202
Closed
parmort wants to merge 1 commit intonvim-lua:masterfrom
Closed
[WIP] Make <CR> "extensible" for other plugins.#202parmort wants to merge 1 commit intonvim-lua:masterfrom
parmort wants to merge 1 commit intonvim-lua:masterfrom
Conversation
Got every case except when the menu is visible and nothing is selected. You have to hit <CR> twice to trigger previous mapping.
Author
|
Right now, I have most of the cases worked out. The only case I can't quite figure out is when the PUM is open and nothing is selected. With the current code, I have to hit |
Author
|
Duplicate of #154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great plugin! I realized that this plugin clobbers any prior mapping to
<CR>in insert-mode. Specifically, I noticed that vim-endwise doesn't work because it maps<CR>, which this plugin clobbers in any buffer where it is activated.When I used COC, I ran into the same problem. This comment is my solution to that problem: map a plugin mapping to the added functionality and chain that to the desired mapping.