Conversation
I'm not a maintainer, so please don't take my word as gospel, or as a replacement for the maintainer's word. However, for something like this, I think it'd make sense to just add new commits as you find things to fix. If a PR gets merged, and you find more things to fix, then you make a new PR. That said, I also get if you don't want to keep opening new PRs - maybe it's annoying to make new branches, or you feel like it's bothering the maintainers. So I think what you've done here is equally as valid - marking the PR as a draft until you've had time to go through everything. Again, I'm not a maintainer of nushell, so it's possible the maintainers may disagree... but I still hope my viewpoint helps. |
|
Thanks for the feedback. Opening a new PR isn't much work on my end. It's more concern regarding bothering the maintainers. They've been so responsive and helpful I don't want to take advantage of that. Just want to know what they want to do it that way. |
Found another one. I think I'm done reading for today. What frequency should I make the pull requests? I don't want to do them too often but I also don't want them to get too stale. What frequency seems good to you. I'll just set a reminder to send them at that frequency instead of when I find them.