Skip to content

Minor typo fixes#2131

Draft
c-git wants to merge 1 commit intonushell:mainfrom
c-git:patch-2
Draft

Minor typo fixes#2131
c-git wants to merge 1 commit intonushell:mainfrom
c-git:patch-2

Conversation

@c-git
Copy link
Contributor

@c-git c-git commented Feb 28, 2026

Found another one. I think I'm done reading for today. What frequency should I make the pull requests? I don't want to do them too often but I also don't want them to get too stale. What frequency seems good to you. I'll just set a reminder to send them at that frequency instead of when I find them.

@LikeLakers2
Copy link
Contributor

What frequency should I make the pull requests? I don't want to do them too often but I also don't want them to get too stale. What frequency seems good to you.

I'm not a maintainer, so please don't take my word as gospel, or as a replacement for the maintainer's word.

However, for something like this, I think it'd make sense to just add new commits as you find things to fix. If a PR gets merged, and you find more things to fix, then you make a new PR.

That said, I also get if you don't want to keep opening new PRs - maybe it's annoying to make new branches, or you feel like it's bothering the maintainers.

So I think what you've done here is equally as valid - marking the PR as a draft until you've had time to go through everything.

Again, I'm not a maintainer of nushell, so it's possible the maintainers may disagree... but I still hope my viewpoint helps.

@c-git
Copy link
Contributor Author

c-git commented Feb 28, 2026

Thanks for the feedback. Opening a new PR isn't much work on my end. It's more concern regarding bothering the maintainers. They've been so responsive and helpful I don't want to take advantage of that. Just want to know what they want to do it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants