Skip to content

Move _ShapeLike from numpy._typing to public numtype#854

Open
Aniketsy wants to merge 1 commit intonumpy:mainfrom
Aniketsy:fix-565
Open

Move _ShapeLike from numpy._typing to public numtype#854
Aniketsy wants to merge 1 commit intonumpy:mainfrom
Aniketsy:fix-565

Conversation

@Aniketsy
Copy link
Copy Markdown

fixes #565

  • Move _ShapeLike from private numpy._typing to public _numtype module .
  • there were 695 reference

@jorenham just helping with this refactor 😊
please let me know if there is preferred approach for this refactor or we need any improvements

Copy link
Copy Markdown
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Linting issues aside, I'd prefer we now refer to _nt.ShapeLike directly, rather than introducing new type aliases in every module that uses it.

@Aniketsy
Copy link
Copy Markdown
Author

Linting issues aside, I'd prefer we now refer to _nt.ShapeLike directly, rather than introducing new type aliases in every module that uses it.

yes, i was thinking for this but wasn’t completely sure .Thanks! I’ll use _nt.ShapeLike directly. also does this means we need to refactor similarly for other refactors also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move numpy._typing._ShapeLike to numtype

2 participants