MAINT: Fix two cases of code injection via template expansion#39
Open
agriyakhetarpal wants to merge 1 commit intonumpy:mainfrom
Open
MAINT: Fix two cases of code injection via template expansion#39agriyakhetarpal wants to merge 1 commit intonumpy:mainfrom
agriyakhetarpal wants to merge 1 commit intonumpy:mainfrom
Conversation
Member
|
Thanks @agriyakhetarpal. I'm not sure this is a valid concern for this repo, given that we don't run CI on PRs from anyone but release team and org admin members. So the reason to change this would be to make using |
Author
|
Thanks @rgommers. Indeed, this only changes what I saw through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two cases of template injection that Zizmor caught, from a local run.
cc: @rgommers