Skip to content

fix(docs): respect dark theme in badge style dropdown#2913

Open
BittuBarnwal7479 wants to merge 1 commit into
npmx-dev:mainfrom
BittuBarnwal7479:codex/fix-badge-style-dark-theme
Open

fix(docs): respect dark theme in badge style dropdown#2913
BittuBarnwal7479 wants to merge 1 commit into
npmx-dev:mainfrom
BittuBarnwal7479:codex/fix-badge-style-dark-theme

Conversation

@BittuBarnwal7479

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#2885

🧭 Context

📚 Description

The Badge Style dropdown on the Badges page does not fully respect the active dark theme. When opened in dark mode, the dropdown menu appears with light styling, causing inconsistent appearance and reduced readability. The dropdown should match the active theme for a consistent user experience.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jun 15, 2026 12:09am
npmx.dev Ready Ready Preview, Comment Jun 15, 2026 12:09am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Jun 15, 2026 12:09am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 85460847-160a-45c2-b68c-0fecdf188256

📥 Commits

Reviewing files that changed from the base of the PR and between 604dc92 and be3fd49.

📒 Files selected for processing (1)
  • docs/app/components/BadgeGeneratorParameters.vue

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Improved dark mode appearance of Badge Generator style options to enhance visibility and consistency when using dark mode.

Walkthrough

In BadgeGeneratorParameters.vue, the v-for-rendered <option> elements inside the "Badge Style" <select> now include a class="dark:bg-gray-900" attribute for dark-mode background styling. The surrounding template block was reformatted without altering control flow or bindings.

Changes

Badge Style Dropdown Dark Mode

Layer / File(s) Summary
Dark mode class on Badge Style options
docs/app/components/BadgeGeneratorParameters.vue
Each <option> generated from the styles array now carries class="dark:bg-gray-900". Template block whitespace was also reformatted with no logic changes.

Possibly Related Issues

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding dark theme support to the badge style dropdown component.
Description check ✅ Passed The description is directly related to the changeset, explaining the dark theme issue in the Badge Style dropdown and why the fix is needed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant