Skip to content

refactor: fix or suppress existing oxlint warnings #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhalp wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

refactor: fix or suppress existing oxlint warnings #2634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/Package/TrendsChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,7 @@ const normalisedDataset = computed(() => {
const lastDateMs = chartData.value.dates.at(-1) ?? 0
const isAbsoluteMetric = selectedMetric.value === 'contributors'

// oxlint-disable-next-line oxc-no-map-spread
Copy link
Copy Markdown
Member Author

@serhalp serhalp Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://discord.com/channels/1464542801676206113/1467137249195065435/1498086643175919748

Copy link
Copy Markdown
Contributor

@gameroman gameroman Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe disable the rule in the config?

return (chartData.value.dataset || []).map(d => {
const series = applyDataPipeline(
d.series.map(v => v ?? 0),
Expand Down
2 changes: 1 addition & 1 deletion app/composables/useSelectedPackageManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const useSelectedPackageManager = createSharedComposable(
// Sync to data-pm attribute on the client
if (import.meta.client) {
const queryPM = new URLSearchParams(window.location.search).get('pm')
if (queryPM && packageManagers.some(pm => pm.id === queryPM)) {
if (queryPM && packageManagers.some(({ id }) => id === queryPM)) {
pm.value = queryPM as PackageManagerId
}
// Watch for changes and update the attribute
Expand Down
2 changes: 1 addition & 1 deletion server/utils/readme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ export async function renderReadmeHtml(
return `<h${semanticLevel} id="${id}" data-level="${depth}"${preservedAttrs}><a href="#${id}">${displayHtml}</a></h${semanticLevel}>\n`
}

const anchorTokenRegex = /^<a(\s.+)?\/?>$/
const anchorTokenRegex = /^<a(?:\s.+)?\/?>$/
renderer.heading = function ({ tokens, depth }: Tokens.Heading) {
const isAnchorHeading =
anchorTokenRegex.test(tokens[0]?.raw ?? '') && tokens[tokens.length - 1]?.raw === '</a>'
Expand Down
Loading