fix: add clear button in search field (mobile view)#1895
fix: add clear button in search field (mobile view)#1895SahulKola wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
f619f50 to
2b9581d
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Header SearchBox component adds a computed 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| <button | ||
| v-if="hasSearchQuery" | ||
| type="button" | ||
| :aria-label="$t('common.close')" | ||
| class="absolute inset-ie-2 inline-flex h-6 w-6 items-center justify-center rounded text-fg-muted hover:text-fg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent" | ||
| @click="clearSearch" | ||
| > | ||
| <span class="i-lucide:circle-x h-4 w-4" aria-hidden="true" /> | ||
| </button> |
There was a problem hiding this comment.
Use the global focus-visible rule for this button.
This button currently adds inline focus-visible:* utilities, which conflicts with the repo-wide button focus strategy and can create inconsistent focus treatment.
Suggested change
- class="absolute inset-ie-2 inline-flex h-6 w-6 items-center justify-center rounded text-fg-muted hover:text-fg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent"
+ class="absolute inset-ie-2 inline-flex h-6 w-6 items-center justify-center rounded text-fg-muted hover:text-fg"Based on learnings: focus-visible styling for button/select must be handled globally in app/assets/main.css, and per-element inline focus-visible utility classes should be avoided.
2b9581d to
747a1dd
Compare
747a1dd to
8bcbeed
Compare
🔗 Linked issue
Resolves #1881
🧭 Context
📚 Description