Skip to content

fix: improve versions modal input alignment#1553

Merged
alexdln merged 7 commits intonpmx-dev:mainfrom
iiio2:fix/improve-version-modal-input-alignment
Feb 27, 2026
Merged

fix: improve versions modal input alignment#1553
alexdln merged 7 commits intonpmx-dev:mainfrom
iiio2:fix/improve-version-modal-input-alignment

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 21, 2026

Before:
before

After:
after

@vercel
Copy link

vercel bot commented Feb 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 27, 2026 0:58am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 27, 2026 0:58am
npmx-lunaria Ignored Ignored Feb 27, 2026 0:58am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the TrendsChart Vue component with layout adjustments to the reset date button. The padding increases from py-1.75 to py-2.25, and the undo icon span element changes from inline to block display. These changes affect the vertical spacing and presentation of the reset button and its associated icon without altering the component's core functionality.

Possibly related PRs

Suggested labels

help wanted

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description contains before/after images demonstrating the UI changes to the Versions modal, directly relating to the changeset modifications in TrendsChart.vue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros
Copy link
Contributor

When a custom date selection is applied, a reset button is displayed on the right side:

image

The height of this button could probably be adjusted as well to match the inputs'

@alexdln
Copy link
Member

alexdln commented Feb 27, 2026

The issue somehow managed to be corrected by deleting the field 😅

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ab6733 and 65ea1cd.

📒 Files selected for processing (1)
  • app/components/Package/TrendsChart.vue

@alexdln alexdln added this pull request to the merge queue Feb 27, 2026
Merged via the queue into npmx-dev:main with commit 71eba9d Feb 27, 2026
18 checks passed
@iiio2
Copy link
Contributor Author

iiio2 commented Feb 27, 2026

Thanks. 😊

@iiio2 iiio2 deleted the fix/improve-version-modal-input-alignment branch February 27, 2026 13:45
@alexdln
Copy link
Member

alexdln commented Feb 27, 2026

@iiio2 Thanks for the PR ❤️

If you'd like to continue this topic or had trouble working on this one, I've created an issue to standartise sizes
#1706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants